Page MenuHomePhabricator
Differential D4354

[services][identity] helper function to start PAKE registration
ClosedPublic
Actions

Authored by varun on Jun 24 2022, 8:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 12:18 AM
Unknown Object (File)
Mon, Mar 31, 1:49 AM
Unknown Object (File)
Wed, Mar 19, 6:50 PM
Unknown Object (File)
Fri, Mar 14, 10:01 AM
Unknown Object (File)
Sun, Mar 9, 5:50 PM
Unknown Object (File)
Mar 4 2025, 1:53 AM
Unknown Object (File)
Mar 1 2025, 9:17 AM
Unknown Object (File)
Feb 26 2025, 7:51 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
• jim
tomek
• karol
Commits
rCOMMdff52153004a: [services][identity] helper function to start PAKE registration
Summary

checks the state of the stream (that the number of messages received matches expectation), starts PAKE registration, updates state, and returns a RegistrationResponse

Depends on D4352

Test Plan

Tested along with the following two diffs by calling the register_user RPC

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jun 24 2022, 8:56 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJun 24 2022, 8:56 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 24 2022, 9:05 AM
Harbormaster failed remote builds in B9953: Diff 13766!
varun requested review of this revision.Jun 24 2022, 9:11 AM
varun added a child revision: D4359: [services][identity] pake registration finish helper.Jun 26 2022, 11:56 PM
varun updated this revision to Diff 13810.Jun 27 2022, 12:14 AM

Change Option<String> variables to String vars

Harbormaster completed remote builds in B9993: Diff 13810.Jun 27 2022, 12:31 AM
varun updated this revision to Diff 13819.Jun 27 2022, 1:03 AM

rebase

Harbormaster completed remote builds in B10002: Diff 13819.Jun 27 2022, 1:39 AM
tomek requested changes to this revision.Jun 27 2022, 4:26 AM
tomek added inline comments.
services/identity/src/service.rs
82–83 ↗(On Diff #13819)

Maybe String::new()?

90 ↗(On Diff #13819)

What if this expression is false? Is it an error or something we should safely ignore?

95–107 ↗(On Diff #13819)

There are a lot of options to reduce the indentation, e.g. by creating more variables

112–113 ↗(On Diff #13819)

Is it possible for a single expression to do this assignment?

574 ↗(On Diff #13819)

We should avoid modifying the parameters and instead return result value

This revision now requires changes to proceed.Jun 27 2022, 4:26 AM
varun updated this revision to Diff 13856.Jun 27 2022, 2:36 PM
varun marked 2 inline comments as done.

address feedback

varun added inline comments.Jun 27 2022, 2:38 PM
services/identity/src/service.rs
90 ↗(On Diff #13819)

this was handled in a subsequent diff, but now that i'm refactoring this code to make it flatter, i'm combining this case with the "message is Error" case since we handle them the same

95–107 ↗(On Diff #13819)

i've flattened by changing the patterns in the match statement. i can do this, too, if you think the code is still too nested

112–113 ↗(On Diff #13819)

no i think that only works if registration_response_and_server_registration is a tuple

Harbormaster completed remote builds in B10021: Diff 13856.Jun 27 2022, 2:43 PM
tomek accepted this revision.Jun 28 2022, 6:06 AM
varun removed 1 blocking reviewer(s): • jim.Jun 28 2022, 6:44 AM
This revision is now accepted and ready to land.Jun 28 2022, 6:44 AM
Closed by commit rCOMMdff52153004a: [services][identity] helper function to start PAKE registration (authored by varun). · Explain WhyJun 28 2022, 7:12 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMdff52153004a: [services][identity] helper function to start PAKE registration.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
16 lines
105 lines

Diff 13810

View Options

services/identity/src/config.rs

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Linestype Props = {
+currentTabType: TabType, +currentTabType: TabType,
+setCurrentTabType: SetState<TabType>, +setCurrentTabType: SetState<TabType>,
+queuedChanges: ThreadChanges, +queuedChanges: ThreadChanges,
+setQueuedChanges: SetState<ThreadChanges>, +setQueuedChanges: SetState<ThreadChanges>,
+namePlaceholder: string, +namePlaceholder: string,
+changeQueued: boolean, +changeQueued: boolean,
+setTab: (tabType: TabType) => void, +setTab: (tabType: TabType) => void,
+onChangeName: (event: SyntheticEvent<HTMLInputElement>) => void, +onChangeName: (event: SyntheticEvent<HTMLInputElement>) => void,
+onChangeDescription: (event: SyntheticEvent<HTMLTextAreaElement>) => void,
}; };
class ThreadSettingsModal extends React.PureComponent<Props> { class ThreadSettingsModal extends React.PureComponent<Props> {
nameInput: ?HTMLInputElement; nameInput: ?HTMLInputElement;
accountPasswordInput: ?HTMLInputElement; accountPasswordInput: ?HTMLInputElement;
constructor(props: Props) { constructor(props: Props) {
super(props); super(props);
} }
▲ Show 20 Lines • Show All 59 Lines • ▼ Show 20 Lines if (this.props.currentTabType === 'general') {
mainContent = ( mainContent = (
<ThreadSettingsGeneralTab <ThreadSettingsGeneralTab
threadNameValue={firstLine(this.possiblyChangedValue('name'))} threadNameValue={firstLine(this.possiblyChangedValue('name'))}
threadNamePlaceholder={this.props.namePlaceholder} threadNamePlaceholder={this.props.namePlaceholder}
threadNameOnChange={this.props.onChangeName} threadNameOnChange={this.props.onChangeName}
threadNameDisabled={inputDisabled} threadNameDisabled={inputDisabled}
threadNameInputRef={this.nameInputRef} threadNameInputRef={this.nameInputRef}
threadDescriptionValue={this.possiblyChangedValue('description')} threadDescriptionValue={this.possiblyChangedValue('description')}
threadDescriptionOnChange={this.onChangeDescription} threadDescriptionOnChange={this.props.onChangeDescription}
threadDescriptionDisabled={inputDisabled} threadDescriptionDisabled={inputDisabled}
threadColorCurrentColor={this.possiblyChangedValue('color')} threadColorCurrentColor={this.possiblyChangedValue('color')}
threadColorOnColorSelection={this.onChangeColor} threadColorOnColorSelection={this.onChangeColor}
/> />
); );
} else if (this.props.currentTabType === 'privacy') { } else if (this.props.currentTabType === 'privacy') {
mainContent = ( mainContent = (
<ThreadSettingsPrivacyTab <ThreadSettingsPrivacyTab
▲ Show 20 Lines • Show All 102 Lines • ▼ Show 20 Linesclass ThreadSettingsModal extends React.PureComponent<Props> {
nameInputRef = (nameInput: ?HTMLInputElement) => { nameInputRef = (nameInput: ?HTMLInputElement) => {
this.nameInput = nameInput; this.nameInput = nameInput;
}; };
accountPasswordInputRef = (accountPasswordInput: ?HTMLInputElement) => { accountPasswordInputRef = (accountPasswordInput: ?HTMLInputElement) => {
this.accountPasswordInput = accountPasswordInput; this.accountPasswordInput = accountPasswordInput;
}; };
onChangeDescription = (event: SyntheticEvent<HTMLTextAreaElement>) => {
const target = event.currentTarget;
const newValue =
target.value !== this.props.threadInfo.description
? target.value
: undefined;
this.props.setQueuedChanges({
...this.props.queuedChanges,
description: newValue,
});
};
onChangeColor = (color: string) => { onChangeColor = (color: string) => {
const newValue = color !== this.props.threadInfo.color ? color : undefined; const newValue = color !== this.props.threadInfo.color ? color : undefined;
this.props.setQueuedChanges({ this.props.setQueuedChanges({
...this.props.queuedChanges, ...this.props.queuedChanges,
color: newValue, color: newValue,
}); });
}; };
▲ Show 20 Lines • Show All 128 Lines • ▼ Show 20 Lines const onChangeName = React.useCallback(
name: firstLine( name: firstLine(
target.value !== threadInfo.name ? target.value : undefined, target.value !== threadInfo.name ? target.value : undefined,
), ),
}); });
}, },
[queuedChanges, threadInfo], [queuedChanges, threadInfo],
); );
const onChangeDescription = React.useCallback(
(event: SyntheticEvent<HTMLTextAreaElement>) => {
invariant(threadInfo, 'threadInfo should exist in onChangeDescription');
const target = event.currentTarget;
setQueuedChanges({
...queuedChanges,
description:
target.value !== threadInfo.description ? target.value : undefined,
});
},
[queuedChanges, threadInfo],
);
if (!threadInfo) { if (!threadInfo) {
return ( return (
<Modal onClose={modalContext.clearModal} name="Invalid thread"> <Modal onClose={modalContext.clearModal} name="Invalid thread">
<div className={css.modal_body}> <div className={css.modal_body}>
<p>You no longer have permission to view this thread</p> <p>You no longer have permission to view this thread</p>
</div> </div>
</Modal> </Modal>
); );
Show All 17 Lines return (
currentTabType={currentTabType} currentTabType={currentTabType}
setCurrentTabType={setCurrentTabType} setCurrentTabType={setCurrentTabType}
queuedChanges={queuedChanges} queuedChanges={queuedChanges}
setQueuedChanges={setQueuedChanges} setQueuedChanges={setQueuedChanges}
namePlaceholder={namePlaceholder} namePlaceholder={namePlaceholder}
changeQueued={changeQueued} changeQueued={changeQueued}
setTab={setTab} setTab={setTab}
onChangeName={onChangeName} onChangeName={onChangeName}
onChangeDescription={onChangeDescription}
/> />
); );
}, },
); );
export default ConnectedThreadSettingsModal; export default ConnectedThreadSettingsModal;
View Options

services/identity/src/service.rs

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Linestype Props = {
+currentTabType: TabType, +currentTabType: TabType,
+setCurrentTabType: SetState<TabType>, +setCurrentTabType: SetState<TabType>,
+queuedChanges: ThreadChanges, +queuedChanges: ThreadChanges,
+setQueuedChanges: SetState<ThreadChanges>, +setQueuedChanges: SetState<ThreadChanges>,
+namePlaceholder: string, +namePlaceholder: string,
+changeQueued: boolean, +changeQueued: boolean,
+setTab: (tabType: TabType) => void, +setTab: (tabType: TabType) => void,
+onChangeName: (event: SyntheticEvent<HTMLInputElement>) => void, +onChangeName: (event: SyntheticEvent<HTMLInputElement>) => void,
+onChangeDescription: (event: SyntheticEvent<HTMLTextAreaElement>) => void,
}; };
class ThreadSettingsModal extends React.PureComponent<Props> { class ThreadSettingsModal extends React.PureComponent<Props> {
nameInput: ?HTMLInputElement; nameInput: ?HTMLInputElement;
accountPasswordInput: ?HTMLInputElement; accountPasswordInput: ?HTMLInputElement;
constructor(props: Props) { constructor(props: Props) {
super(props); super(props);
} }
▲ Show 20 Lines • Show All 59 Lines • ▼ Show 20 Lines if (this.props.currentTabType === 'general') {
mainContent = ( mainContent = (
<ThreadSettingsGeneralTab <ThreadSettingsGeneralTab
threadNameValue={firstLine(this.possiblyChangedValue('name'))} threadNameValue={firstLine(this.possiblyChangedValue('name'))}
threadNamePlaceholder={this.props.namePlaceholder} threadNamePlaceholder={this.props.namePlaceholder}
threadNameOnChange={this.props.onChangeName} threadNameOnChange={this.props.onChangeName}
threadNameDisabled={inputDisabled} threadNameDisabled={inputDisabled}
threadNameInputRef={this.nameInputRef} threadNameInputRef={this.nameInputRef}
threadDescriptionValue={this.possiblyChangedValue('description')} threadDescriptionValue={this.possiblyChangedValue('description')}
threadDescriptionOnChange={this.onChangeDescription} threadDescriptionOnChange={this.props.onChangeDescription}
threadDescriptionDisabled={inputDisabled} threadDescriptionDisabled={inputDisabled}
threadColorCurrentColor={this.possiblyChangedValue('color')} threadColorCurrentColor={this.possiblyChangedValue('color')}
threadColorOnColorSelection={this.onChangeColor} threadColorOnColorSelection={this.onChangeColor}
/> />
); );
} else if (this.props.currentTabType === 'privacy') { } else if (this.props.currentTabType === 'privacy') {
mainContent = ( mainContent = (
<ThreadSettingsPrivacyTab <ThreadSettingsPrivacyTab
▲ Show 20 Lines • Show All 102 Lines • ▼ Show 20 Linesclass ThreadSettingsModal extends React.PureComponent<Props> {
nameInputRef = (nameInput: ?HTMLInputElement) => { nameInputRef = (nameInput: ?HTMLInputElement) => {
this.nameInput = nameInput; this.nameInput = nameInput;
}; };
accountPasswordInputRef = (accountPasswordInput: ?HTMLInputElement) => { accountPasswordInputRef = (accountPasswordInput: ?HTMLInputElement) => {
this.accountPasswordInput = accountPasswordInput; this.accountPasswordInput = accountPasswordInput;
}; };
onChangeDescription = (event: SyntheticEvent<HTMLTextAreaElement>) => {
const target = event.currentTarget;
const newValue =
target.value !== this.props.threadInfo.description
? target.value
: undefined;
this.props.setQueuedChanges({
...this.props.queuedChanges,
description: newValue,
});
};
onChangeColor = (color: string) => { onChangeColor = (color: string) => {
const newValue = color !== this.props.threadInfo.color ? color : undefined; const newValue = color !== this.props.threadInfo.color ? color : undefined;
this.props.setQueuedChanges({ this.props.setQueuedChanges({
...this.props.queuedChanges, ...this.props.queuedChanges,
color: newValue, color: newValue,
}); });
}; };
▲ Show 20 Lines • Show All 128 Lines • ▼ Show 20 Lines const onChangeName = React.useCallback(
name: firstLine( name: firstLine(
target.value !== threadInfo.name ? target.value : undefined, target.value !== threadInfo.name ? target.value : undefined,
), ),
}); });
}, },
[queuedChanges, threadInfo], [queuedChanges, threadInfo],
); );
const onChangeDescription = React.useCallback(
(event: SyntheticEvent<HTMLTextAreaElement>) => {
invariant(threadInfo, 'threadInfo should exist in onChangeDescription');
const target = event.currentTarget;
setQueuedChanges({
...queuedChanges,
description:
target.value !== threadInfo.description ? target.value : undefined,
});
},
[queuedChanges, threadInfo],
);
if (!threadInfo) { if (!threadInfo) {
return ( return (
<Modal onClose={modalContext.clearModal} name="Invalid thread"> <Modal onClose={modalContext.clearModal} name="Invalid thread">
<div className={css.modal_body}> <div className={css.modal_body}>
<p>You no longer have permission to view this thread</p> <p>You no longer have permission to view this thread</p>
</div> </div>
</Modal> </Modal>
); );
Show All 17 Lines return (
currentTabType={currentTabType} currentTabType={currentTabType}
setCurrentTabType={setCurrentTabType} setCurrentTabType={setCurrentTabType}
queuedChanges={queuedChanges} queuedChanges={queuedChanges}
setQueuedChanges={setQueuedChanges} setQueuedChanges={setQueuedChanges}
namePlaceholder={namePlaceholder} namePlaceholder={namePlaceholder}
changeQueued={changeQueued} changeQueued={changeQueued}
setTab={setTab} setTab={setTab}
onChangeName={onChangeName} onChangeName={onChangeName}
onChangeDescription={onChangeDescription}
/> />
); );
}, },
); );
export default ConnectedThreadSettingsModal; export default ConnectedThreadSettingsModal;