checks the state of the stream (that the number of messages received matches expectation), starts PAKE registration, updates state, and returns a RegistrationResponse
Depends on D4352
Details
Details
Tested along with the following two diffs by calling the register_user RPC
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/identity/src/service.rs | ||
|---|---|---|
| 82–83 | Maybe String::new()? | |
| 90 | What if this expression is false? Is it an error or something we should safely ignore? | |
| 95–107 | There are a lot of options to reduce the indentation, e.g. by creating more variables | |
| 112–113 | Is it possible for a single expression to do this assignment? | |
| 574 | We should avoid modifying the parameters and instead return result value | |
| services/identity/src/service.rs | ||
|---|---|---|
| 90 | this was handled in a subsequent diff, but now that i'm refactoring this code to make it flatter, i'm combining this case with the "message is Error" case since we handle them the same | |
| 95–107 | i've flattened by changing the patterns in the match statement. i can do this, too, if you think the code is still too nested | |
| 112–113 | no i think that only works if registration_response_and_server_registration is a tuple | |