Page MenuHomePhabricator

[Services] Generate Protobuf files with CMake
AbandonedPublicDraft

Authored by jon on Jul 3 2022, 8:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 3:43 AM
Unknown Object (File)
Tue, Nov 12, 1:07 AM
Unknown Object (File)
Tue, Nov 5, 2:41 PM
Unknown Object (File)
Tue, Nov 5, 2:41 PM
Unknown Object (File)
Tue, Nov 5, 2:39 PM
Unknown Object (File)
Tue, Nov 5, 7:38 AM
Unknown Object (File)
Oct 16 2024, 5:31 PM
Unknown Object (File)
Oct 16 2024, 5:51 AM

Details

Summary

This is a more opinionated version of D3867,
in which CMake automatically generates the files.

Depends on D4294

Test Plan

nix build .#comm-grpc

or

cd native/cpp/CommonCpp/grpc/ && mkdir build && cd build && cmake .. && make

Diff Detail

Repository
rCOMM Comm
Branch
joringer/cmake-generated-protos
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 3 2022, 9:02 AM
Harbormaster failed remote builds in B10218: Diff 14105!

generated files will be missing @generated, thus not able to be diff'd in current workflow without manual intervention.