Page MenuHomePhabricator

[Services] Generate Protobuf files with CMake
AbandonedPublicDraft

Authored by jon on Jul 3 2022, 8:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 11:29 AM
Unknown Object (File)
Thu, Mar 13, 11:28 AM
Unknown Object (File)
Thu, Mar 13, 11:22 AM
Unknown Object (File)
Feb 20 2025, 2:00 AM
Unknown Object (File)
Feb 7 2025, 1:26 PM
Unknown Object (File)
Feb 4 2025, 6:57 AM
Unknown Object (File)
Jan 31 2025, 5:09 PM
Unknown Object (File)
Jan 30 2025, 9:44 PM

Details

Summary

This is a more opinionated version of D3867,
in which CMake automatically generates the files.

Depends on D4294

Test Plan

nix build .#comm-grpc

or

cd native/cpp/CommonCpp/grpc/ && mkdir build && cd build && cmake .. && make

Diff Detail

Repository
rCOMM Comm
Branch
joringer/cmake-generated-protos
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 3 2022, 9:02 AM
Harbormaster failed remote builds in B10218: Diff 14105!

generated files will be missing @generated, thus not able to be diff'd in current workflow without manual intervention.