Page MenuHomePhabricator

[nix] Add dependencies needed to compile native modules
ClosedPublic

Authored by jon on Jun 19 2022, 11:20 AM.
Tags
None
Referenced Files
F3328861: D4294.id13573.diff
Wed, Nov 20, 4:06 PM
Unknown Object (File)
Wed, Nov 13, 1:11 AM
Unknown Object (File)
Thu, Nov 7, 4:31 PM
Unknown Object (File)
Tue, Nov 5, 8:10 PM
Unknown Object (File)
Tue, Nov 5, 8:10 PM
Unknown Object (File)
Tue, Nov 5, 8:10 PM
Unknown Object (File)
Tue, Nov 5, 8:10 PM
Unknown Object (File)
Tue, Nov 5, 8:10 PM

Details

Summary

Dependencies needed for building cpp services through nix

Depends on D4293

Test Plan

nix develop

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jon retitled this revision from Add dependencies needed to compile native modules to [nix] Add dependencies needed to compile native modules.Jun 19 2022, 11:31 AM

Make openssl available to all platforms for grpc compatibility

nix/overlay.nix
32 ↗(On Diff #13580)

I guess we're doing this so this line works with the new CMake config changes?

jon added inline comments.
nix/overlay.nix
32 ↗(On Diff #13580)

The Session.hh is used in our code, although it's not meant to be publicly exposed by upstream. I added it so I didn't have to also touch c++.

The Session.hh just exposes a bit of abstraction on top of the olm primitives, the intent upstream is for the headers to only be used for their unit tests (which is why it's not exposed publicly)

https://gitlab.matrix.org/matrix-org/olm/-/blob/master/include/olm/session.hh#L20

This revision is now accepted and ready to land.Jun 26 2022, 9:30 PM
This revision now requires review to proceed.Jun 26 2022, 9:30 PM

Please adjust line length before landing!

nix/overlay.nix
29–32 ↗(On Diff #13580)

Makes sense!! Can you make sure to limit all lines to 80 chars?

This revision is now accepted and ready to land.Jun 28 2022, 11:59 AM
This revision was automatically updated to reflect the committed changes.
jon marked an inline comment as done.
jon added inline comments.
nix/overlay.nix
29–32 ↗(On Diff #13580)

Sorry, was pairing with varun, and landed to unblock some work we were doing, will tackle this in another diff

nix/overlay.nix
29–32 ↗(On Diff #13580)

No problem, can you make a Linear task so we don't forget? (Or alternately, feel free to put a diff up right away)

jon added inline comments.
nix/overlay.nix
29–32 ↗(On Diff #13580)