Page MenuHomePhabricator
Differential D4444

Write to temporary message storage from NotificationService
ClosedPublic
Actions

Authored by marcin on Jul 5 2022, 4:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 3:48 AM
Unknown Object (File)
Sat, Nov 2, 5:29 PM
Unknown Object (File)
Sat, Nov 2, 11:15 AM
Unknown Object (File)
Sat, Nov 2, 11:15 AM
Unknown Object (File)
Sat, Nov 2, 11:15 AM
Unknown Object (File)
Sat, Nov 2, 11:15 AM
Unknown Object (File)
Sat, Nov 2, 11:15 AM
Unknown Object (File)
Sat, Nov 2, 11:15 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
Commits
rCOMMbec9a9d332f9: Write to temporary message storage from NotificationService
Summary

In this differential TemporaryMessagesStorage API is used in NotificationService to persist messages before they are written to SQLite.

Test Plan

In the debugger we can track execution to ensure no exception is thrown.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jul 5 2022, 4:53 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJul 5 2022, 4:53 AM
marcin updated this revision to Diff 14176.Jul 5 2022, 4:55 AM

Update commit message

Harbormaster completed remote builds in B10283: Diff 14175.Jul 5 2022, 5:51 AM
Harbormaster completed remote builds in B10284: Diff 14176.Jul 5 2022, 5:57 AM
marcin requested review of this revision.Jul 5 2022, 5:57 AM
marcin updated this revision to Diff 14262.Jul 7 2022, 5:42 AM

Remove call to non-existing ensureLockNotHeld method

marcin added a child revision: D4445: Retrieve messages from temporary message storage in AppDelegate.Jul 7 2022, 5:47 AM
marcin added a parent revision: D4394: Implement read-and-flush operation for flat-file based message storage.
Harbormaster completed remote builds in B10354: Diff 14262.Jul 7 2022, 6:36 AM
marcin updated this revision to Diff 14279.Jul 7 2022, 7:12 AM

Rename Temporal to Temporary

marcin retitled this revision from Write to temporal message storage from NotificationService to Write to temporary message storage from NotificationService.Jul 7 2022, 7:14 AM
marcin edited the summary of this revision. (Show Details)
tomek accepted this revision.Jul 7 2022, 8:23 AM
tomek added inline comments.
native/ios/NotificationService/NotificationService.mm
20–23 ↗(On Diff #14279)

Should we check if messageInfos field is there?

This revision is now accepted and ready to land.Jul 7 2022, 8:23 AM
Harbormaster completed remote builds in B10371: Diff 14279.Jul 7 2022, 8:33 AM
marcin added inline comments.Jul 8 2022, 5:19 AM
native/ios/NotificationService/NotificationService.mm
20–23 ↗(On Diff #14279)

We did so in differential that wrote to SQLite directly from NotificationService (https://phab.comm.dev/D4063), which was accepted. Therefore it is reasonable to do so here as well.

marcin updated this revision to Diff 14357.Jul 8 2022, 6:14 AM

Check against empty message

Harbormaster completed remote builds in B10416: Diff 14357.Jul 8 2022, 6:26 AM
marcin updated this revision to Diff 14472.Jul 14 2022, 4:51 AM

Rebase

Harbormaster completed remote builds in B10523: Diff 14472.Jul 14 2022, 6:03 AM
marcin updated this revision to Diff 14641.Jul 19 2022, 5:54 AM

Rebase

Harbormaster failed remote builds in B10642: Diff 14641!Jul 19 2022, 6:03 AM
marcin updated this revision to Diff 14701.Jul 20 2022, 5:23 AM

Rebase master

This revision was landed with ongoing or failed builds.Jul 20 2022, 6:18 AM
Closed by commit rCOMMbec9a9d332f9: Write to temporary message storage from NotificationService (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMbec9a9d332f9: Write to temporary message storage from NotificationService.
Harbormaster completed remote builds in B10683: Diff 14701.Jul 20 2022, 6:39 AM

Revision Contents
Changeset List

PathSize
native/
ios/
NotificationService/
8 lines

Diff 14708

View Options

native/ios/NotificationService/NotificationService.mm

Loading...