Page MenuHomePhabricator
Differential D4382

Define interface for elementary file operations: atomic write, append, read and atomic truncation with encryption-decryption layer based on encryption key in CommSecureStore
ClosedPublic
Actions

Authored by marcin on Jun 28 2022, 8:33 AM.
Tags
None
Referenced Files
F3211967: D4382.id14221.diff
Sun, Nov 10, 9:27 AM
F3201228: D4382.id14161.diff
Sat, Nov 9, 3:46 PM
F3200622: D4382.id14269.diff
Sat, Nov 9, 2:12 PM
Unknown Object (File)
Sat, Nov 9, 10:17 AM
Unknown Object (File)
Sat, Nov 9, 10:09 AM
Unknown Object (File)
Sat, Nov 9, 7:29 AM
Unknown Object (File)
Sat, Nov 9, 6:26 AM
Unknown Object (File)
Sat, Nov 9, 6:05 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
varun
• karol
Commits
rCOMMbf06baed200b: Define interface for elementary file operations: atomic write, append, read and…
Summary

Defines operations on file we will need to implement message stora in a flat file

Test Plan

No test plan.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jun 28 2022, 8:33 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJun 28 2022, 8:33 AM
Harbormaster completed remote builds in B10057: Diff 13906.Jun 28 2022, 8:42 AM
marcin requested review of this revision.Jun 28 2022, 8:42 AM
marcin added a parent revision: D4381: Implement interface for inter process non-blocking binary lock based on POSIX semaphores.Jun 29 2022, 2:34 AM
marcin added a child revision: D4383: Extend interface for elementary file operations with encryption-decryption layer by Obj-C style private interface for encryption end decryption.
tomek accepted this revision.Jun 29 2022, 6:11 AM
This revision is now accepted and ready to land.Jun 29 2022, 6:11 AM
marcin updated this revision to Diff 14063.Jul 1 2022, 2:01 AM

Introduce files to project.pbxproj

Harbormaster completed remote builds in B10185: Diff 14063.Jul 1 2022, 2:13 AM
marcin updated this revision to Diff 14150.Jul 5 2022, 3:19 AM

Define message separator constant

Harbormaster failed remote builds in B10258: Diff 14150!Jul 5 2022, 3:19 AM
marcin updated this revision to Diff 14161.Jul 5 2022, 3:29 AM

Rebase master

Harbormaster completed remote builds in B10269: Diff 14161.Jul 5 2022, 4:27 AM
marcin updated this revision to Diff 14221.Jul 6 2022, 4:33 AM

Change read operation signature to return list of appended contents

Harbormaster completed remote builds in B10315: Diff 14221.Jul 6 2022, 4:45 AM
marcin updated this revision to Diff 14253.Jul 7 2022, 5:33 AM

Remove clear content method as it is not needed.

Harbormaster completed remote builds in B10345: Diff 14253.Jul 7 2022, 5:45 AM
marcin updated this revision to Diff 14269.Jul 7 2022, 7:06 AM

Rename Temporal to Temporary

Harbormaster completed remote builds in B10361: Diff 14269.Jul 7 2022, 7:24 AM
marcin updated this revision to Diff 14463.Jul 14 2022, 4:48 AM

Rebase

Harbormaster failed remote builds in B10514: Diff 14463!Jul 14 2022, 4:57 AM
This revision was landed with ongoing or failed builds.Jul 14 2022, 5:09 AM
Closed by commit rCOMMbf06baed200b: Define interface for elementary file operations: atomic write, append, read and… (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMbf06baed200b: Define interface for elementary file operations: atomic write, append, read and….
Harbormaster completed remote builds in B10514: Diff 14463.Jul 14 2022, 6:18 AM

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
2 lines
Comm/
TemporaryMessageStorage/
14 lines

Diff 14477

View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...
View Options

native/ios/Comm/TemporaryMessageStorage/EncryptedFileUtils.h

Loading...