Page MenuHomePhabricator

Define interface for flat-file based message storage operations
ClosedPublic

Authored by marcin on Jun 29 2022, 2:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 24, 2:32 PM
Unknown Object (File)
Thu, Oct 24, 8:36 AM
Unknown Object (File)
Wed, Oct 23, 10:43 AM
Unknown Object (File)
Tue, Oct 22, 9:09 PM
Unknown Object (File)
Tue, Oct 22, 9:40 AM
Unknown Object (File)
Sun, Oct 20, 4:27 AM
Unknown Object (File)
Sat, Oct 19, 11:24 AM
Unknown Object (File)
Thu, Oct 10, 10:55 AM

Details

Summary

This diff defines API in the form of Obj-C class that AppDelegate and NotificationService will use to write/retrieve messages temporarilt stored in a flat file.

Test Plan

No test plan. Future diffs that use this API in NotificationService and AppDelegate will provide appropriate test plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Introduce files to project.pbxproj

tomek added inline comments.
native/ios/Comm/TemporalMessageStorage/TemporalMessageStorage.h
5 ↗(On Diff #14067)

I think temporary is preferred in this context

This revision is now accepted and ready to land.Jul 5 2022, 3:07 AM

Change initialization method signature and remove sanity check method

native/ios/Comm/TemporalMessageStorage/TemporalMessageStorage.h
5 ↗(On Diff #14067)

Sure, I will do the renaming.

Rename Temporal to Temporary

This revision was landed with ongoing or failed builds.Jul 14 2022, 5:10 AM
This revision was automatically updated to reflect the committed changes.