Page MenuHomePhabricator
Differential D4469

[web] Introduce "Create new chat" button
ClosedPublic
Actions

Authored by • jacek on Jul 7 2022, 5:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 12:19 AM
Unknown Object (File)
Thu, Nov 21, 7:49 PM
Unknown Object (File)
Tue, Nov 12, 1:12 AM
Unknown Object (File)
Fri, Nov 8, 9:22 PM
Unknown Object (File)
Tue, Nov 5, 5:01 AM
Unknown Object (File)
Sat, Nov 2, 7:01 PM
Unknown Object (File)
Sat, Nov 2, 7:01 PM
Unknown Object (File)
Sat, Nov 2, 7:01 PM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
tomek
atul
• abosh
Commits
rCOMM3dc5eb28e945: [web] Introduce "Create new chat" button
Summary

Primary button allowing to create new chats on the bottom of chat list.
Disabled if already in chat creation mode.

Screenshot_Google Chrome_2022-07-21_144948.png (397×821 px, 37 KB)

Test Plan

Click the button, new chat creation process (with empty user list) should be started.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jacek created this revision.Jul 7 2022, 5:22 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 7 2022, 5:22 AM
Harbormaster completed remote builds in B10343: Diff 14251.Jul 7 2022, 5:34 AM
• jacek requested review of this revision.Jul 7 2022, 5:34 AM
• jacek edited the summary of this revision. (Show Details)Jul 7 2022, 5:55 AM
• jacek added a parent revision: D4466: [web] Introduce `useOnClickNewThread` hook.
• jacek added a parent revision: D4465: [web] Support chat creation in `ChatMessageListContainer`.Jul 7 2022, 6:00 AM
• jacek added a parent revision: D4474: [web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in thread creation mode.Jul 7 2022, 6:41 AM
• jacek added a reviewer: • abosh.Jul 7 2022, 7:22 AM
• jacek updated this revision to Diff 14395.Jul 11 2022, 6:27 AM

rebase

Harbormaster completed remote builds in B10451: Diff 14395.Jul 11 2022, 6:40 AM
• abosh accepted this revision.Jul 14 2022, 9:55 AM

Looks good!

web/chat/chat-thread-list.react.js
59 ↗(On Diff #14395)

This (and the title of this diff) should probably be renamed, as per D4539.

This revision is now accepted and ready to land.Jul 14 2022, 9:55 AM
ashoat added inline comments.Jul 15 2022, 12:44 PM
web/chat/chat-thread-list.react.js
59 ↗(On Diff #14395)

Great catch!!

tomek accepted this revision.Jul 20 2022, 5:10 AM
tomek added inline comments.
web/chat/chat-thread-list.react.js
33 ↗(On Diff #14395)

It's better to keep as much logic in useSelector as possible

• jacek updated this revision to Diff 14769.Jul 21 2022, 5:49 AM

rename thread to chat & address Tomek's comment

• jacek retitled this revision from [web] Introduce "Create new thread" button to [web] Introduce "Create new chat" button.Jul 21 2022, 5:49 AM
• jacek edited the summary of this revision. (Show Details)
• jacek edited the test plan for this revision. (Show Details)
• jacek edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B10730: Diff 14769.Jul 21 2022, 6:07 AM
• jacek added a child revision: D4618: [web] Remove old `NewThreadModal` component.Jul 25 2022, 7:14 AM
• jacek added a parent revision: D4615: [web] Move selected chat to the top of the list in creation mode.
Closed by commit rCOMM3dc5eb28e945: [web] Introduce "Create new chat" button (authored by • jacek). · Explain WhyJul 26 2022, 3:06 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM3dc5eb28e945: [web] Introduce "Create new chat" button.

Revision Contents
Changeset List

PathSize
web/
chat/
4 lines
8 lines
33 lines

Diff 14940

View Options

web/chat/chat-tabs.css

Loading...
View Options

web/chat/chat-thread-list.css

Loading...
View Options

web/chat/chat-thread-list.react.js

Loading...