Page MenuHomePhabricator
Differential D4496

[services] Tunnelbroker - Add Corrosion installation script
ClosedPublic
Actions

Authored by • max on Jul 11 2022, 4:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 26, 7:13 PM
Unknown Object (File)
Tue, Jun 18, 2:23 PM
Unknown Object (File)
Tue, Jun 18, 2:23 PM
Unknown Object (File)
Tue, Jun 18, 2:22 PM
Unknown Object (File)
Tue, Jun 18, 2:19 PM
Unknown Object (File)
Tue, Jun 18, 12:57 PM
Unknown Object (File)
Wed, Jun 12, 7:37 AM
Unknown Object (File)
Thu, Jun 6, 7:52 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• jon
• karol
tomek

Details

Reviewers
varun
• karol
tomek
• abosh
• jon
Commits
rCOMM2d4977700846: [services] Tunnelbroker - Add Corrosion installation script
Summary

This script installs the Corrosion tool to integrate Rust and Cargo into the CMake project.

Linear task: ENG-1329

Test Plan

Successfully built the service using the CmakeLists with a Corrosion as a dependency in D4498.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Jul 11 2022, 4:22 AM
• max held this revision as a draft.
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJul 11 2022, 4:22 AM
Harbormaster completed remote builds in B10444: Diff 14388.Jul 11 2022, 4:35 AM
• max added a child revision: D4497: [services] Tunnelbroker - Install Rust and Corrosion in Dockerfile.Jul 11 2022, 4:37 AM
• max added a child revision: D4498: [services] Tunnelbroker - Add Corrosion to CMakeLists.Jul 11 2022, 4:43 AM
• max edited the summary of this revision. (Show Details)Jul 11 2022, 4:52 AM
• max edited the test plan for this revision. (Show Details)
• max added reviewers: varun, • karol, tomek.
• max mentioned this in D4497: [services] Tunnelbroker - Install Rust and Corrosion in Dockerfile.Jul 11 2022, 4:55 AM
• max added 1 blocking reviewer(s): varun.
• max published this revision for review.Jul 11 2022, 5:05 AM
ashoat added reviewers: • abosh, • jon. ashoat removed 1 blocking reviewer(s): tomek.Jul 11 2022, 6:14 AM
ashoat added a subscriber: • jon.

Adding @jonringer-comm since it's CMake/Rust-related, and adding @yayabosh because there's bash. Also removed @palys-swm as blocking to give him a break :)

• abosh added a comment.Jul 11 2022, 7:48 AM

bash-wise, looks good.

• jon accepted this revision.Jul 11 2022, 8:02 AM

I'm fine with using this. I don't have any experience with this in particular, but looks easy enough to integrate from the README.

Nixpkgs already has it, and it should be trivial to add nix support.

varun accepted this revision.Jul 12 2022, 12:03 PM
This revision is now accepted and ready to land.Jul 12 2022, 12:03 PM
Closed by commit rCOMM2d4977700846: [services] Tunnelbroker - Add Corrosion installation script (authored by • max). · Explain WhyJul 14 2022, 6:23 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM2d4977700846: [services] Tunnelbroker - Add Corrosion installation script.
• max mentioned this in rCOMM6271350404db: [services] Tunnelbroker - Install Rust and Corrosion in Dockerfile.Jul 14 2022, 6:25 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
docker/
13 lines

Diff 14483

View Options

services/tunnelbroker/docker/install_corrosion.sh

Loading...