Paths

Table of Contentst

[services] Backup - Fix unchanged variable names in unit tests scripts
ClosedPublic
Actions

Authored by • jakub on Jul 12 2022, 1:15 AM.

Details

Reviewers

• karol
tomek
• max
varun
ashoat

Commits

rCOMM158b8632d463: [services] Backup - Fix unchanged variable names in unit tests scripts

Summary

Fixing unchanged variable names in integration tests script and unit tests scripts from DEV_MODE to SANDBOX.

Test Plan

cd services && yarn run-unit-tests backup

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jakub created this revision.Jul 12 2022, 1:15 AM

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJul 12 2022, 1:15 AM

• jakub added a child revision: D4503: [services] Backup - Fix missing hash in unit tests.Jul 12 2022, 1:23 AM

Harbormaster completed remote builds in B10459: Diff 14404.Jul 12 2022, 1:28 AM

• jakub requested review of this revision.Jul 12 2022, 1:28 AM

• jakub edited the summary of this revision. (Show Details)Jul 12 2022, 1:57 AM

• jakub edited the test plan for this revision. (Show Details)

• jakub added reviewers: • karol, tomek.

• jakub edited the test plan for this revision. (Show Details)Jul 12 2022, 2:15 AM

Nice catch!! In this case I think @geekbrother is the best reviewer, since he was the one that introduced the DEV_MODE -> SANDBOX change.

(Sorry for accidental commandeer)

ashoat resigned from this revision.Jul 12 2022, 12:03 PM

varun accepted this revision.Jul 12 2022, 12:21 PM

This revision is now accepted and ready to land.Jul 12 2022, 12:21 PM

• karol accepted this revision.Jul 18 2022, 1:26 AM

tomek accepted this revision.Jul 18 2022, 5:34 AM

Closed by commit rCOMM158b8632d463: [services] Backup - Fix unchanged variable names in unit tests scripts (authored by • jakub). · Explain WhyJul 27 2022, 7:35 AM

This revision was automatically updated to reflect the committed changes.

• jakub added a commit: rCOMM158b8632d463: [services] Backup - Fix unchanged variable names in unit tests scripts.

Revision Contents
Changeset List

Path

Size

services/

scripts/

run_integration_tests.sh

2 lines

run_unit_tests.sh

2 lines

Diff 14404

View Options

services/scripts/run_integration_tests.sh