Linear issue:
https://linear.app/comm/issue/ENG-1357/rename-sidebar-to-thread-in-product-copy
Diff renames thread to chat in all strings displayed to the user in native
Details
Details
- Reviewers
tomek ashoat • jacek - Commits
- rCOMM9e4270d1e526: [native] Rename thread to chat
Checked if strings changed as expected in web or mobile.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks great, just some small comments!
| native/chat/compose-subchannel.react.js | ||
|---|---|---|
| 221 ↗ | (On Diff #14497) | Since this is specifically for channels, I think we can say "Existing channels" |
| 308 ↗ | (On Diff #14497) | Since this is specifically for channels, I think we can say "create a channel containing only yourself" |
| native/chat/settings/thread-settings-promote-sidebar.react.js | ||
| 29 ↗ | (On Diff #14497) | Sidebars can only be promoted to channels, so we can say "full channel" here |
| 61 ↗ | (On Diff #14497) | Can we say "Promote to channel" instead of "Promote to full chat"? |
| native/chat/settings/thread-settings-promote-sidebar.react.js | ||
|---|---|---|
| 29 ↗ | (On Diff #14497) | Should it still say "full"? Since we're changing "full chat" to "channel" everywhere else |
| native/chat/settings/thread-settings-promote-sidebar.react.js | ||
|---|---|---|
| 29 ↗ | (On Diff #14511) | Should it still say "full"? Since we've changed "full chat" to "channel" everywhere else |
Comment Actions
Awesome, this looks great! (Make sure to respond to the inline comment before landing.)
| native/chat/settings/thread-settings-promote-sidebar.react.js | ||
|---|---|---|
| 29 ↗ | (On Diff #14511) | Yeah, good suggestion! We should use "channel" instead of "full channel" |
Comment Actions
Change "full channel" to "channel" in native/chat/settings/thread-settings-promote-sidebar.react.js
Comment Actions
Should I be responding to all comments? Or is sometimes doing what the comment requests enough (with simpler tasks)?
| native/chat/settings/thread-settings-promote-sidebar.react.js | ||
|---|---|---|
| 29 ↗ | (On Diff #14511) | Done! |
Comment Actions
Ah, instead of "make sure to respond" I should've said "make sure to address". It's not strictly necessary to write a comment in response to each comment... I just wanted to make sure that "full channel" got updated to "channel" before you landed.