grpc.cmake
ClosedPublic
Actions

Authored by • jon on Jul 18 2022, 4:24 PM.

Details

Reviewers

atul
varun
• max
• karol

Commits

rCOMMda9e2fc2f98f: [Chore] Lint services/lib/cmake-components/grpc.cmake

Summary

Lint cmake helper file

Test Plan

nix develop
cmake-lint services/backup/CMakeLists.txt

Depends on D4564

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jul 18 2022, 4:24 PM

Herald added subscribers: • abosh, • adrian, tomek, ashoat. · View Herald TranscriptJul 18 2022, 4:24 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 18 2022, 4:28 PM

Harbormaster failed remote builds in B10606: Diff 14599!

Rebase

• jon added a child revision: D4548: [BuildKite] Add cmake lint gate.Jul 18 2022, 4:43 PM

Harbormaster completed remote builds in B10611: Diff 14604.Jul 18 2022, 4:55 PM

• jon requested review of this revision.Jul 18 2022, 4:55 PM

atul accepted this revision.Jul 18 2022, 6:00 PM

This revision is now accepted and ready to land.Jul 18 2022, 6:00 PM

Closed by commit rCOMMda9e2fc2f98f: [Chore] Lint services/lib/cmake-components/grpc.cmake (authored by • jon). · Explain WhyJul 20 2022, 12:00 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMda9e2fc2f98f: [Chore] Lint services/lib/cmake-components/grpc.cmake.

Revision Contents
Changeset List

Path

Size

services/

lib/

cmake-components/

grpc.cmake

3 lines

Diff 14724

View Options

services/lib/cmake-components/grpc.cmake

Show All 20 Lines	function SidebarItem(props: Props): React.Node {
} = threadInfo;		} = threadInfo;

const onClick = useOnClickThread(threadInfo);		const onClick = useOnClickThread(threadInfo);

const unreadCls = classNames(css.sidebarTitle, { [css.unread]: unread });		const unreadCls = classNames(css.sidebarTitle, { [css.unread]: unread });

return (		return (
<>		<>
<SWMansionIcon icon="right-angle-arrow" size={28} />		<SWMansionIcon icon="right-angle-arrow" color="transparent" size={28} />
<div className={css.spacer} />		<div className={css.spacer} />
<a className={css.threadButtonSidebar} onClick={onClick}>		<a className={css.threadButtonSidebar} onClick={onClick}>
<div className={css.threadRow}>		<div className={css.threadRow}>
<div className={unreadCls}>{threadInfo.uiName}</div>		<div className={unreadCls}>{threadInfo.uiName}</div>
</div>		</div>
</a>		</a>
</>		</>
);		);
}		}

export default SidebarItem;		export default SidebarItem;

[Chore] Lint services/lib/cmake-components/grpc.cmakeClosedPublicActions