CMakeLists.txt
ClosedPublic
Actions

Authored by • jon on Jul 18 2022, 10:38 PM.

Details

Reviewers

atul
varun
• max
• karol

Commits

rCOMMf981ac14a205: [Chore] Lint services/backup/CMakeLists.txt

Summary

Lint backup

Test Plan

nix develop
cmake-lint services/backup/CMakeLists.txt

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jul 18 2022, 10:38 PM

Herald added subscribers: • abosh, • adrian, tomek, ashoat. · View Herald TranscriptJul 18 2022, 10:38 PM

• jon added a child revision: D4564: [Nix] Add cmake-format to dev shell.Jul 18 2022, 10:40 PM

• jon removed a child revision: D4564: [Nix] Add cmake-format to dev shell.

• jon added a parent revision: D4564: [Nix] Add cmake-format to dev shell.

Harbormaster completed remote builds in B10601: Diff 14594.Jul 18 2022, 10:52 PM

• jon requested review of this revision.Jul 18 2022, 10:52 PM

Nice!

This revision is now accepted and ready to land.Jul 18 2022, 11:04 PM

Rebase

Harbormaster completed remote builds in B10602: Diff 14595.Jul 18 2022, 11:32 PM

• jon added a child revision: D4548: [BuildKite] Add cmake lint gate.Jul 18 2022, 11:43 PM

ashoat added inline comments.Jul 19 2022, 3:16 PM

services/backup/CMakeLists.txt
115 ↗	(On Diff #14595)	This extraneous newline isn't necessary, but if the linter is adding it that's okay. Consistency is more important than being compatible with my preferences :)

Remove extraneous newline

• jon marked an inline comment as done.Jul 20 2022, 6:52 PM

• jon added inline comments.

services/backup/CMakeLists.txt
115 ↗	(On Diff #14595)	that was my bad

• jon marked an inline comment as done.Jul 20 2022, 6:59 PM

This revision was landed with ongoing or failed builds.Jul 20 2022, 7:00 PM

Closed by commit rCOMMf981ac14a205: [Chore] Lint services/backup/CMakeLists.txt. · Explain Why

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMf981ac14a205: [Chore] Lint services/backup/CMakeLists.txt.

Harbormaster completed remote builds in B10693: Diff 14718.Jul 20 2022, 7:04 PM

Revision Contents
Changeset List

Path

Size

services/

backup/

CMakeLists.txt

8 lines

Diff 14720

View Options

services/backup/CMakeLists.txt

[Chore] Lint services/backup/CMakeLists.txtClosedPublicActions