Page MenuHomePhabricator
Differential D4565

[Chore] Lint services/backup/CMakeLists.txt
ClosedPublic
Actions

Authored by • jon on Jul 18 2022, 3:38 PM.
Tags
None
Referenced Files
F2829082: D4565.diff
Fri, Sep 27, 3:24 PM
Unknown Object (File)
Tue, Sep 3, 9:37 AM
Unknown Object (File)
Tue, Sep 3, 9:37 AM
Unknown Object (File)
Tue, Sep 3, 9:37 AM
Unknown Object (File)
Tue, Sep 3, 9:37 AM
Unknown Object (File)
Tue, Sep 3, 9:36 AM
Unknown Object (File)
Tue, Sep 3, 9:27 AM
Unknown Object (File)
Aug 27 2024, 10:16 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
tomek

Details

Reviewers
atul
varun
• max
• karol
Commits
rCOMMf981ac14a205: [Chore] Lint services/backup/CMakeLists.txt
Summary

Lint backup

Test Plan
nix develop
cmake-lint services/backup/CMakeLists.txt

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jul 18 2022, 3:38 PM
Herald added subscribers: • abosh, • adrian, tomek, ashoat. · View Herald TranscriptJul 18 2022, 3:38 PM
• jon added a child revision: D4564: [Nix] Add cmake-format to dev shell.Jul 18 2022, 3:40 PM
• jon removed a child revision: D4564: [Nix] Add cmake-format to dev shell.
• jon added a parent revision: D4564: [Nix] Add cmake-format to dev shell.
Harbormaster completed remote builds in B10601: Diff 14594.Jul 18 2022, 3:52 PM
• jon requested review of this revision.Jul 18 2022, 3:52 PM
atul accepted this revision.Jul 18 2022, 4:04 PM

Nice!

This revision is now accepted and ready to land.Jul 18 2022, 4:04 PM
• jon updated this revision to Diff 14595.Jul 18 2022, 4:19 PM

Rebase

Harbormaster completed remote builds in B10602: Diff 14595.Jul 18 2022, 4:32 PM
• jon added a child revision: D4548: [BuildKite] Add cmake lint gate.Jul 18 2022, 4:43 PM
ashoat added inline comments.Jul 19 2022, 8:16 AM
services/backup/CMakeLists.txt
115 ↗(On Diff #14595)

This extraneous newline isn't necessary, but if the linter is adding it that's okay. Consistency is more important than being compatible with my preferences :)

• jon updated this revision to Diff 14718.Jul 20 2022, 11:51 AM

Remove extraneous newline

• jon marked an inline comment as done.Jul 20 2022, 11:52 AM
• jon added inline comments.
services/backup/CMakeLists.txt
115 ↗(On Diff #14595)

that was my bad

• jon marked an inline comment as done.Jul 20 2022, 11:59 AM
This revision was landed with ongoing or failed builds.Jul 20 2022, 12:00 PM
Closed by commit rCOMMf981ac14a205: [Chore] Lint services/backup/CMakeLists.txt (authored by • jon). · Explain Why
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMf981ac14a205: [Chore] Lint services/backup/CMakeLists.txt.
Harbormaster completed remote builds in B10693: Diff 14718.Jul 20 2022, 12:04 PM

Revision Contents
Changeset List

PathSize
services/
backup/
8 lines

Diff 14718

View Options

services/backup/CMakeLists.txt

Loading...