[lib, native, web] Remove showingSidebarsInline variable and button text option "See threads..."
ClosedPublic
Actions

Authored by inka on Jul 19 2022, 7:01 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMe7979bf66618: [lib, native, web] Remove showingSidebarsInline variable and button text option…

Summary

There was some obsolete code that got never called since diff D1487. It got removed.
showingSidebarsInline was indeed obsolete as the only function that used it - ChatThreadListSeeMoreSidebars - was called inside an ‘if’ not allowing sidebarsItems.length to be 0 and the variable was being set as showingSidebarsInline: sidebarItems.length !== 0
Thus the code defined for when showingSidebarsInline == 0 got removed as well.

Linear issue: https://linear.app/comm/issue/ENG-1426/delete-see-threads-button-text-option

Test Plan

Check that everything still compiles.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jul 19 2022, 7:01 AM

Herald added subscribers: • abosh, atul, • adrian. · View Herald TranscriptJul 19 2022, 7:02 AM

Harbormaster completed remote builds in B10646: Diff 14646.Jul 19 2022, 7:14 AM

inka requested review of this revision.Jul 19 2022, 7:14 AM

inka retitled this revision from Remove showingSidebarsInline variable and button text option "See threads..." to [lib, native, web] Remove showingSidebarsInline variable and button text option "See threads...".Jul 19 2022, 7:20 AM

Thank you!!

native/chat/chat-thread-list-see-more-sidebars.react.js
28 ↗	(On Diff #14646)	We can probably just move this to appear inline on line 38 now
web/chat/chat-thread-list-see-more-sidebars.react.js
24 ↗	(On Diff #14646)	We can probably just move this to appear inline on line 36 now