Page MenuHomePhabricator
Differential D4584

[services] Tests - Add REMOVE for Blob performance tests
ClosedPublic
Actions

Authored by • karol on Jul 20 2022, 4:15 AM.
Tags
None
Referenced Files
F2213708: D4584.diff
Mon, Jul 8, 2:05 PM
Unknown Object (File)
Sat, Jul 6, 5:08 PM
Unknown Object (File)
Sat, Jul 6, 8:39 AM
Unknown Object (File)
Sat, Jul 6, 8:38 AM
Unknown Object (File)
Sat, Jul 6, 8:38 AM
Unknown Object (File)
Sat, Jul 6, 8:37 AM
Unknown Object (File)
Sat, Jul 6, 8:34 AM
Unknown Object (File)
Thu, Jul 4, 4:45 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
Commits
rCOMMb525823ae3e2: [services] Tests - Add REMOVE for Blob performance tests
Summary

Depends on D4583

Adding the logic for the remove operations.

Test Plan
cd services
yarn run-performance-tests blob

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Jul 20 2022, 4:15 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 20 2022, 4:16 AM
• karol edited the summary of this revision. (Show Details)Jul 20 2022, 4:35 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, varun.
• karol added a parent revision: D4583: [services] Tests - Add GET for Blob performance tests.
• karol added a child revision: D4585: [services] Tests - Improve logging for Blob tests.
• karol updated this revision to Diff 14688.Jul 20 2022, 4:40 AM
• karol edited the summary of this revision. (Show Details)

remove log line

Harbormaster completed remote builds in B10666: Diff 14683.Jul 20 2022, 4:46 AM
• karol added inline comments.Jul 20 2022, 4:47 AM
services/commtest/tests/blob_performance_test.rs
103 ↗(On Diff #14683)

should be removed

• karol updated this revision to Diff 14694.Jul 20 2022, 5:02 AM

lazily add stuff

Harbormaster completed remote builds in B10671: Diff 14688.Jul 20 2022, 5:18 AM
Harbormaster completed remote builds in B10676: Diff 14694.Jul 20 2022, 5:52 AM
• karol requested review of this revision.Jul 20 2022, 5:52 AM
tomek accepted this revision.Jul 21 2022, 5:11 AM
This revision is now accepted and ready to land.Jul 21 2022, 5:11 AM
• karol updated this revision to Diff 15053.Jul 28 2022, 6:11 AM

rebase

Harbormaster completed remote builds in B10943: Diff 15053.Jul 28 2022, 6:30 AM
Closed by commit rCOMMb525823ae3e2: [services] Tests - Add REMOVE for Blob performance tests (authored by • karol). · Explain WhyAug 2 2022, 3:02 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMb525823ae3e2: [services] Tests - Add REMOVE for Blob performance tests.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
19 lines

Diff 15191

View Options

services/commtest/tests/blob_performance_test.rs

Loading...