Page MenuHomePhabricator
Differential D4591

[services] Lib - Remove couts or replace them with glog
ClosedPublic
Actions

Authored by • karol on Jul 21 2022, 3:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:13 AM
Unknown Object (File)
Tue, Nov 5, 2:05 AM
Unknown Object (File)
Sat, Nov 2, 10:54 AM
Unknown Object (File)
Wed, Oct 23, 5:45 PM
Unknown Object (File)
Oct 4 2024, 12:10 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
• max
Commits
rCOMMe8d3d360d3c0: [services] Lib - Remove couts or replace them with glog
Summary

Depends on D4590

Adding an initialization of the glog functionalities.
Removing std::couts or replacing them with glog functions for the services' library.

Test Plan
cd services
yarn run-backup-service-in-sandbox
yarn run-blob-service-in-sandbox

Builds ok

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Jul 21 2022, 3:45 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 21 2022, 3:45 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 3:47 AM
Harbormaster failed remote builds in B10711: Diff 14750!
• karol edited the summary of this revision. (Show Details)Jul 21 2022, 4:03 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D4590: [services] Blob - Remove couts or replace them with glog.
• karol updated this revision to Diff 14762.Jul 21 2022, 4:04 AM
• karol edited the summary of this revision. (Show Details)

CI

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 4:06 AM
Harbormaster failed remote builds in B10723: Diff 14762!
• karol added a child revision: D4592: [services] Tunnelbroker - remove include iostream.Jul 21 2022, 4:06 AM
• karol requested review of this revision.Jul 21 2022, 4:18 AM

Services built properly

• max accepted this revision.Jul 21 2022, 6:56 AM

Looks good!

This revision is now accepted and ready to land.Jul 21 2022, 6:56 AM
• karol added 1 blocking reviewer(s): tomek.Jul 21 2022, 7:38 AM
This revision now requires review to proceed.Jul 21 2022, 7:38 AM
tomek accepted this revision.Jul 22 2022, 3:41 AM
This revision is now accepted and ready to land.Jul 22 2022, 3:41 AM
This revision was landed with ongoing or failed builds.Jul 26 2022, 7:11 AM
Closed by commit rCOMMe8d3d360d3c0: [services] Lib - Remove couts or replace them with glog (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMe8d3d360d3c0: [services] Lib - Remove couts or replace them with glog.

Revision Contents
Changeset List

PathSize
services/
lib/
src/
client-base-reactors/
4 lines
4 lines
4 lines
server-base-reactors/
4 lines
6 lines

Diff 14762

View Options

services/lib/src/client-base-reactors/ClientBidiReactorBase.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientReadReactorBase.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientWriteReactorBase.h

Loading...
View Options

services/lib/src/server-base-reactors/ServerReadReactorBase.h

Loading...
View Options

services/lib/src/server-base-reactors/ServerWriteReactorBase.h

Loading...