Depends on D4633
Adding a piece of test for "add attachments for logs" functionality.
Details
Details
cd services yarn run-performance-tests backup 1
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/commtest/tests/backup_performance_test.rs | ||
|---|---|---|
| 188–201 | i think it makes more sense to check if not empty then do something | |
| services/commtest/tests/backup_performance_test.rs | ||
|---|---|---|
| 188–201 | ||
| services/commtest/tests/backup_performance_test.rs | ||
|---|---|---|
| 188–201 | There's an implicit return at the end of add_attachments::run() so I think the "return early" idea is fulfilled either way. I think it's bad style to introduce an explicit return when it's unneeded. Separately, return () is equivalent to return and the latter is more readable (no chance of someone confusing unit for a function call). | |
| services/commtest/tests/backup_performance_test.rs | ||
|---|---|---|
| 188–201 | Is there a way to do this without increasing indentation? My #1 biggest pet peeve with Rust code is that it tends to be extremely indented, which I think really affects readability | |
| services/commtest/tests/backup_performance_test.rs | ||
|---|---|---|
| 188–201 |
I share that gripe, but in this case the indentation doesn't really change. Current: if item_cloned.backup_item.attachments_holders.is_empty() {
return ();
}
add_attachments::run(&mut client_cloned, &item_cloned, None)
.await
.unwrap();My suggestion: if !item_cloned.backup_item.attachments_holders.is_empty() {
add_attachments::run(&mut client_cloned, &item_cloned, None)
.await
.unwrap();
} | |
| services/commtest/tests/backup_performance_test.rs | ||
|---|---|---|
| 188–201 | Understood... sorry for the noise | |