Page MenuHomePhabricator
Differential D4635

[services] Tests - Backup - Move compare backups to backup utils
ClosedPublic
Actions

Authored by • karol on Jul 26 2022, 2:35 AM.
Tags
None
Referenced Files
F2213509: D4635.diff
Mon, Jul 8, 1:25 PM
F2211257: D4635.id.diff
Mon, Jul 8, 1:36 AM
Unknown Object (File)
Sat, Jul 6, 11:47 AM
Unknown Object (File)
Sat, Jul 6, 11:46 AM
Unknown Object (File)
Sat, Jul 6, 11:46 AM
Unknown Object (File)
Sat, Jul 6, 11:46 AM
Unknown Object (File)
Sat, Jul 6, 11:46 AM
Unknown Object (File)
Fri, Jul 5, 2:23 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
Commits
rCOMM72db45ea8145: [services] Tests - Backup - Move compare backups to backup utils
Summary

Depends on D4634

Excluding the functionality of comparing the backups from the backup integration test into the backup utils so it can also be used in the backup performance tests.

Test Plan
cd services
yarn run-performance-tests backup 1

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Jul 26 2022, 2:35 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 26 2022, 2:35 AM
• karol edited the summary of this revision. (Show Details)Jul 26 2022, 2:44 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, varun.
• karol added a parent revision: D4634: [services] Tests - Backup - Add attachments for logs.
• karol added a child revision: D4636: [services] Tests - Backup - Pull backup.
Harbormaster completed remote builds in B10864: Diff 14927.Jul 26 2022, 2:56 AM
• karol requested review of this revision.Jul 26 2022, 2:56 AM
tomek accepted this revision.Jul 26 2022, 5:35 AM
tomek added inline comments.
services/commtest/tests/backup_performance_test.rs
182

Please fix this in the diff that introduced this code

This revision is now accepted and ready to land.Jul 26 2022, 5:35 AM
• karol updated this revision to Diff 14965.Jul 26 2022, 6:27 AM
• karol edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B10887: Diff 14965.Jul 26 2022, 6:39 AM
Closed by commit rCOMM72db45ea8145: [services] Tests - Backup - Move compare backups to backup utils (authored by • karol). · Explain WhyAug 2 2022, 3:02 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM72db45ea8145: [services] Tests - Backup - Move compare backups to backup utils.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
backup/
43 lines
40 lines
2 lines

Diff 14927

View Options

services/commtest/tests/backup/backup_utils.rs

Loading...
View Options

services/commtest/tests/backup_integration_test.rs

Loading...
View Options

services/commtest/tests/backup_performance_test.rs

Loading...