Related Linear issue here. This diff ensures developers install ShellCheck into their dev environments so that it can run with lint-staged on to-be-committed *.sh files.
D4772 adds the rule to lint all to-be-committed *.sh files.
Details
Details
Tested brew install shellcheck && brew upgrade shellcheck locally on Apple silicon Macbook. On Apple silicon, running which shellcheck should point to /opt/homebrew/bin/shellcheck.
Additionally, created a commit with a problematic *.sh file (after incorporating the changes in D4772) and lint-staged/shellcheck caught the error.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| docs/dev_environment.md | ||
|---|---|---|
| 337–343 ↗ | (On Diff #15425) | Can we move this closer to the rest of the brew install commands? |
Comment Actions
Sure, that makes sense. Moved ShellCheck instructions up to the top of the Prerequisites section under Rust and above Yarn (to keep it "alphabetized"?). It's such a small command I doubt it should be an issue, but open to thoughts about where to place it in the doc.