Page MenuHomePhabricator
Differential D4803

[services] Tunnelbroker - Update Cargo dependencies with the CXX
ClosedPublic
Actions

Authored by • max on Aug 11 2022, 3:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 4, 3:43 PM
Unknown Object (File)
Thu, Mar 20, 12:07 PM
Unknown Object (File)
Wed, Mar 19, 7:29 PM
Unknown Object (File)
Wed, Mar 19, 7:29 PM
Unknown Object (File)
Wed, Mar 19, 7:29 PM
Unknown Object (File)
Sun, Mar 16, 12:08 AM
Unknown Object (File)
Mar 6 2025, 6:34 AM
Unknown Object (File)
Mar 4 2025, 3:16 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol
tomek

Details

Reviewers
• karol
varun
tomek
• jon
ashoat
Commits
rCOMM57cbac818e83: [services] Tunnelbroker - Update Cargo dependencies with the CXX
Summary

This small diff introduces updating Cargo dependencies with the CXX to avoid using unsafe.

Related Linear task: ENG-1438

Test Plan

Successfully run cargo build inside the services/tunnelbroker/rust-notifications folder.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Aug 11 2022, 3:46 AM
• max held this revision as a draft.
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptAug 11 2022, 3:46 AM
• max added a child revision: D4804: [services] Tunnelbroker - Update Cargo dependencies with the Log crate.Aug 11 2022, 3:54 AM
Harbormaster completed remote builds in B11293: Diff 15542.Aug 11 2022, 3:56 AM
• max added a child revision: D4807: [services] Tunnelbroker - Update CMakeLists and Cargo build with the CXX integration updates.Aug 11 2022, 4:16 AM
• max published this revision for review.Aug 11 2022, 4:21 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added reviewers: • karol, varun, tomek.
• max added a reviewer: • jon.Aug 11 2022, 4:24 AM
tomek accepted this revision.Aug 11 2022, 4:59 AM
tomek added a reviewer: ashoat.
ashoat accepted this revision.Aug 11 2022, 6:14 AM
This revision is now accepted and ready to land.Aug 11 2022, 6:14 AM
Closed by commit rCOMM57cbac818e83: [services] Tunnelbroker - Update Cargo dependencies with the CXX (authored by • max). · Explain WhyAug 16 2022, 3:01 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM57cbac818e83: [services] Tunnelbroker - Update Cargo dependencies with the CXX.
• max removed a child revision: D4807: [services] Tunnelbroker - Update CMakeLists and Cargo build with the CXX integration updates.Aug 18 2022, 8:21 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
rust-notifications/
4 lines

Diff 15643

View Options

services/tunnelbroker/rust-notifications/Cargo.lock

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Lines default_action {
type = "forward" type = "forward"
forward { forward {
# ECS target group # ECS target group
target_group { target_group {
arn = aws_lb_target_group.identity_service_grpc.arn arn = aws_lb_target_group.identity_service_grpc.arn
weight = 1 weight = 1
} }
# Legacy EC2 Target # Legacy EC2 Target
target_group { dynamic "target_group" {
arn = data.aws_lb_target_group.identity_service_legacy_ec2.arn for_each = data.aws_lb_target_group.identity_service_legacy_ec2
content {
arn = target_group.value["arn"]
weight = 0 weight = 0
} }
} }
} }
}
lifecycle { lifecycle {
# Required only for existing resources to avoid plan difference # Required only for existing resources to avoid plan difference
ignore_changes = [default_action[0].forward[0].stickiness[0].duration] ignore_changes = [default_action[0].forward[0].stickiness[0].duration]
# Target group cannot be destroyed if it is used # Target group cannot be destroyed if it is used
replace_triggered_by = [aws_lb_target_group.identity_service_grpc] replace_triggered_by = [aws_lb_target_group.identity_service_grpc]
} }
} }
# SSL Certificate # SSL Certificate
data "aws_acm_certificate" "identity_service" { data "aws_acm_certificate" "identity_service" {
domain = "identity.commtechnologies.org" domain = "identity.commtechnologies.org"
statuses = ["ISSUED"] statuses = ["ISSUED"]
} }
# Legacy EC2 instance target # Legacy EC2 instance target
data "aws_lb_target_group" "identity_service_legacy_ec2" { data "aws_lb_target_group" "identity_service_legacy_ec2" {
# We don't have legacy EC2 services in staging
count = local.is_staging ? 0 : 1
name = "identity-service-tg" name = "identity-service-tg"
} }
# Required for Route53 DNS record # Required for Route53 DNS record
output "identity_service_load_balancer_dns_name" { output "identity_service_load_balancer_dns_name" {
value = aws_lb.identity_service.dns_name value = aws_lb.identity_service.dns_name
} }
View Options

services/tunnelbroker/rust-notifications/Cargo.toml

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Lines default_action {
type = "forward" type = "forward"
forward { forward {
# ECS target group # ECS target group
target_group { target_group {
arn = aws_lb_target_group.identity_service_grpc.arn arn = aws_lb_target_group.identity_service_grpc.arn
weight = 1 weight = 1
} }
# Legacy EC2 Target # Legacy EC2 Target
target_group { dynamic "target_group" {
arn = data.aws_lb_target_group.identity_service_legacy_ec2.arn for_each = data.aws_lb_target_group.identity_service_legacy_ec2
content {
arn = target_group.value["arn"]
weight = 0 weight = 0
} }
} }
} }
}
lifecycle { lifecycle {
# Required only for existing resources to avoid plan difference # Required only for existing resources to avoid plan difference
ignore_changes = [default_action[0].forward[0].stickiness[0].duration] ignore_changes = [default_action[0].forward[0].stickiness[0].duration]
# Target group cannot be destroyed if it is used # Target group cannot be destroyed if it is used
replace_triggered_by = [aws_lb_target_group.identity_service_grpc] replace_triggered_by = [aws_lb_target_group.identity_service_grpc]
} }
} }
# SSL Certificate # SSL Certificate
data "aws_acm_certificate" "identity_service" { data "aws_acm_certificate" "identity_service" {
domain = "identity.commtechnologies.org" domain = "identity.commtechnologies.org"
statuses = ["ISSUED"] statuses = ["ISSUED"]
} }
# Legacy EC2 instance target # Legacy EC2 instance target
data "aws_lb_target_group" "identity_service_legacy_ec2" { data "aws_lb_target_group" "identity_service_legacy_ec2" {
# We don't have legacy EC2 services in staging
count = local.is_staging ? 0 : 1
name = "identity-service-tg" name = "identity-service-tg"
} }
# Required for Route53 DNS record # Required for Route53 DNS record
output "identity_service_load_balancer_dns_name" { output "identity_service_load_balancer_dns_name" {
value = aws_lb.identity_service.dns_name value = aws_lb.identity_service.dns_name
} }