Paths

Table of Contentst

[services] Tunnelbroker - Update Cargo dependencies with the CXX
ClosedPublic
Actions

Authored by • max on Aug 11 2022, 10:46 AM.

Details

Reviewers

• karol
varun
tomek
• jon
ashoat

Commits

rCOMM57cbac818e83: [services] Tunnelbroker - Update Cargo dependencies with the CXX

Summary

This small diff introduces updating Cargo dependencies with the CXX to avoid using unsafe.

Related Linear task: ENG-1438

Test Plan

Successfully run cargo build inside the services/tunnelbroker/rust-notifications folder.

Diff Detail

Repository

rCOMM Comm

Branch

add-cxx-to-cargo-dependencies

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Aug 11 2022, 10:46 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptAug 11 2022, 10:46 AM

• max added a child revision: D4804: [services] Tunnelbroker - Update Cargo dependencies with the Log crate.Aug 11 2022, 10:54 AM

Harbormaster completed remote builds in B11293: Diff 15542.Aug 11 2022, 10:56 AM

• max added a child revision: D4807: [services] Tunnelbroker - Update CMakeLists and Cargo build with the CXX integration updates.Aug 11 2022, 11:16 AM

• max published this revision for review.Aug 11 2022, 11:21 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • karol, varun, tomek.

• max added a reviewer: • jon.Aug 11 2022, 11:24 AM

tomek accepted this revision.Aug 11 2022, 11:59 AM

tomek added a reviewer: ashoat.

ashoat accepted this revision.Aug 11 2022, 1:14 PM

This revision is now accepted and ready to land.Aug 11 2022, 1:14 PM

Closed by commit rCOMM57cbac818e83: [services] Tunnelbroker - Update Cargo dependencies with the CXX. · Explain WhyAug 16 2022, 10:01 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM57cbac818e83: [services] Tunnelbroker - Update Cargo dependencies with the CXX.

• max removed a child revision: D4807: [services] Tunnelbroker - Update CMakeLists and Cargo build with the CXX integration updates.Aug 18 2022, 3:21 PM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

rust-notifications/

Cargo.lock

Cargo.toml

4 lines

Diff 15542

View Options

services/tunnelbroker/rust-notifications/Cargo.lock