Page MenuHomePhabricator

[native] add blocking version of get_user_id method
ClosedPublic

Authored by varun on Aug 11 2022, 12:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 3, 6:18 PM
Unknown Object (File)
Tue, Jul 2, 8:36 PM
Unknown Object (File)
Sat, Jun 29, 11:28 PM
Unknown Object (File)
Wed, Jun 26, 2:30 AM
Unknown Object (File)
Wed, Jun 26, 2:30 AM
Unknown Object (File)
Wed, Jun 26, 2:29 AM
Unknown Object (File)
Wed, Jun 26, 2:26 AM
Unknown Object (File)
May 27 2024, 2:21 AM

Details

Summary

Essentially converts the async get_user_id method to a sync method by blocking until the future is resolved. We do this because async functions are not allowed in the CXX bridge yet.

Depends on D4802

Test Plan

Successfully called the sync version and get a response from the Identity service.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 11 2022, 12:31 PM
Harbormaster failed remote builds in B11322: Diff 15579!
varun requested review of this revision.Aug 11 2022, 8:42 PM

Android build failure is unrelated

This revision is now accepted and ready to land.Aug 12 2022, 3:55 AM
This revision was landed with ongoing or failed builds.Aug 18 2022, 11:34 AM
This revision was automatically updated to reflect the committed changes.