Page MenuHomePhabricator
Differential D4854

[native] helper to handle unexpected response
ClosedPublic
Actions

Authored by varun on Aug 16 2022, 8:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 16, 7:16 AM
Unknown Object (File)
Sat, Mar 15, 7:41 PM
Unknown Object (File)
Thu, Mar 6, 5:04 AM
Unknown Object (File)
Thu, Mar 6, 5:04 AM
Unknown Object (File)
Thu, Mar 6, 5:04 AM
Unknown Object (File)
Wed, Mar 5, 6:00 PM
Unknown Object (File)
Wed, Mar 5, 6:00 PM
Unknown Object (File)
Wed, Mar 5, 6:00 PM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
tomek
atul
• karol
Commits
rCOMM0299679da81e: [native] helper to handle unexpected response
Summary

We log the same error and return the same status multiple times, so I've moved this logic to a separate helper function.

Test Plan

cargo build; this logic will get tested more by the functions that call it

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
grpc/
grpc_client/
src/
10 lines

Diff 15719

View Options

native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs

// @flow // @flow
import Clipboard from '@react-native-clipboard/clipboard'; import Clipboard from '@react-native-clipboard/clipboard';
import * as React from 'react'; import * as React from 'react';
import { Text, View } from 'react-native'; import { Text, View } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js';
import { threadHasPermission } from 'lib/shared/thread-utils.js'; import { threadHasPermission } from 'lib/shared/thread-utils.js';
import type { InviteLink } from 'lib/types/link-types.js'; import type { InviteLink } from 'lib/types/link-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import SingleLine from '../components/single-line.react.js'; import SingleLine from '../components/single-line.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
Show All 20 Lines
function ViewInviteLinksScreen(props: Props): React.Node { function ViewInviteLinksScreen(props: Props): React.Node {
const { community } = props.route.params; const { community } = props.route.params;
const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[ const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[
community.id community.id
]; ];
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const { modalForegroundLabel } = useColors(); const { modalForegroundLabel } = useColors();
const linkUrl = inviteLinkUrl(inviteLink?.name ?? ''); const linkUrl = inviteLinkURL(inviteLink?.name ?? '');
const onPressCopy = React.useCallback(() => { const onPressCopy = React.useCallback(() => {
Clipboard.setString(linkUrl); Clipboard.setString(linkUrl);
setTimeout(confirmCopy); setTimeout(confirmCopy);
}, [linkUrl]); }, [linkUrl]);
const { navigate } = props.navigation; const { navigate } = props.navigation;
const onEditButtonClick = React.useCallback(() => { const onEditButtonClick = React.useCallback(() => {
navigate<'ManagePublicLink'>({ navigate<'ManagePublicLink'>({
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines