[native] helper to handle unexpected response
ClosedPublic
Actions

Authored by varun on Aug 16 2022, 8:24 PM.

Details

Reviewers

tomek
atul
• karol

Commits

rCOMM0299679da81e: [native] helper to handle unexpected response

Summary

We log the same error and return the same status multiple times, so I've moved this logic to a separate helper function.

Test Plan

cargo build; this logic will get tested more by the functions that call it

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Aug 16 2022, 8:24 PM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptAug 16 2022, 8:24 PM

varun added a child revision: D4855: [native] helper to handle registration response.Aug 16 2022, 8:26 PM

Harbormaster completed remote builds in B11407: Diff 15696.Aug 16 2022, 8:34 PM

varun requested review of this revision.Aug 16 2022, 8:34 PM

tomek accepted this revision.Aug 17 2022, 6:12 AM

This revision is now accepted and ready to land.Aug 17 2022, 6:12 AM

Closed by commit rCOMM0299679da81e: [native] helper to handle unexpected response (authored by varun). · Explain WhyAug 17 2022, 7:54 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM0299679da81e: [native] helper to handle unexpected response.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

grpc_client/

src/

lib.rs

10 lines

Diff 15719

View Options

native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines	createSelector(stateSyncSpecSelectors, (...specs) => {
return { specsPerHashKey, specPerInnerHashKey };		return { specsPerHashKey, specPerInnerHashKey };
});		});

const getClientResponsesSelector: (		const getClientResponsesSelector: (
state: AppState,		state: AppState,
) => (		) => (
calendarActive: boolean,		calendarActive: boolean,
oneTimeKeyGenerator: ?OneTimeKeyGenerator,		oneTimeKeyGenerator: ?OneTimeKeyGenerator,
getSignedIdentityKeysBlob: ?() => Promise<SignedIdentityKeysBlob>,		getSignedIdentityKeysBlob: () => Promise<SignedIdentityKeysBlob>,
getInitialNotificationsEncryptedMessage: ?() => Promise<string>,		getInitialNotificationsEncryptedMessage: ?() => Promise<string>,
serverRequests: $ReadOnlyArray<ClientServerRequest>,		serverRequests: $ReadOnlyArray<ClientServerRequest>,
) => Promise<$ReadOnlyArray<ClientClientResponse>> = createSelector(		) => Promise<$ReadOnlyArray<ClientClientResponse>> = createSelector(
boundStateSyncSpecsSelector,		boundStateSyncSpecsSelector,
currentCalendarQuery,		currentCalendarQuery,
(		(
{ specsPerHashKey, specPerInnerHashKey },		{ specsPerHashKey, specPerInnerHashKey },
calendarQuery: (calendarActive: boolean) => CalendarQuery,		calendarQuery: (calendarActive: boolean) => CalendarQuery,
) => {		) => {
return async (		return async (
calendarActive: boolean,		calendarActive: boolean,
oneTimeKeyGenerator: ?OneTimeKeyGenerator,		oneTimeKeyGenerator: ?OneTimeKeyGenerator,
getSignedIdentityKeysBlob: ?() => Promise<SignedIdentityKeysBlob>,		getSignedIdentityKeysBlob: () => Promise<SignedIdentityKeysBlob>,
getInitialNotificationsEncryptedMessage: ?() => Promise<string>,		getInitialNotificationsEncryptedMessage: ?() => Promise<string>,
serverRequests: $ReadOnlyArray<ClientServerRequest>,		serverRequests: $ReadOnlyArray<ClientServerRequest>,
): Promise<$ReadOnlyArray<ClientClientResponse>> => {		): Promise<$ReadOnlyArray<ClientClientResponse>> => {
const clientResponses = [];		const clientResponses = [];
const serverRequestedPlatformDetails = serverRequests.some(		const serverRequestedPlatformDetails = serverRequests.some(
request => request.type === serverRequestTypes.PLATFORM_DETAILS,		request => request.type === serverRequestTypes.PLATFORM_DETAILS,
);		);
for (const serverRequest of serverRequests) {		for (const serverRequest of serverRequests) {
▲ Show 20 Lines • Show All 68 Lines • ▼ Show 20 Lines	): Promise<$ReadOnlyArray<ClientClientResponse>> => {
for (let i = 0; i < minimumOneTimeKeysRequired; ++i) {		for (let i = 0; i < minimumOneTimeKeysRequired; ++i) {
keys.push(oneTimeKeyGenerator(i));		keys.push(oneTimeKeyGenerator(i));
}		}
clientResponses.push({		clientResponses.push({
type: serverRequestTypes.MORE_ONE_TIME_KEYS,		type: serverRequestTypes.MORE_ONE_TIME_KEYS,
keys,		keys,
});		});
} else if (		} else if (
serverRequest.type === serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB &&		serverRequest.type === serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB
getSignedIdentityKeysBlob
) {		) {
const signedIdentityKeysBlob = await getSignedIdentityKeysBlob();		const signedIdentityKeysBlob = await getSignedIdentityKeysBlob();
clientResponses.push({		clientResponses.push({
type: serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB,		type: serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB,
signedIdentityKeysBlob,		signedIdentityKeysBlob,
});		});
} else if (		} else if (
serverRequest.type ===		serverRequest.type ===
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines

[native] helper to handle unexpected responseClosedPublicActions