Page MenuHomePhabricator

[native] Update `SWMansionIcon` component with cleaned up icons
ClosedPublic

Authored by atul on Aug 17 2022, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 5:21 AM
Unknown Object (File)
Sun, Nov 3, 2:20 PM
Unknown Object (File)
Sun, Nov 3, 2:20 PM
Unknown Object (File)
Sun, Nov 3, 2:16 PM
Unknown Object (File)
Oct 18 2024, 5:25 AM
Unknown Object (File)
Oct 16 2024, 9:30 AM
Unknown Object (File)
Oct 14 2024, 10:12 PM
Unknown Object (File)
Oct 10 2024, 4:17 AM
Subscribers

Details

Summary

It took a while to clean up the source vectors (converting strokes to outlines, joining paths w/ union, subtract, intersect, difference properly, flattening things, getting alignment correct, getting things exported properly, etc).

Once that was all figured out, imported the cleaned up icons into IcoMoon and prepared for export. Retrieved the relevant TTF fonts and JSON config from IcoMoon and replaced the existing fonts/config in the project.

Everything continues to look as expected (or better), but a few icon names have changed. I'll add the icon name changes to this diff to avoid spamming Phabricator with a bunch of rename diffs.


We're now including the entire SWMansion icon pack (all 275 icons) so we should hopefully never have to look at this again. If we have additional icons we want to include in the future, they'll live in (the much smaller) CommIcons pack.

Test Plan

Tested the native app via the iOS Simulator and the icons appeared as expected. There are a few icons that didn't appear and had a ? in their place. I went through and replaced the old icon names with the corresponding new ones.

But other than that, it looks like this change went smoothly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Aug 17 2022, 7:32 PM

replace old icon names w/ new icon names (the ones actually from the icon pack)

There are a few icons that don't appear and have a in their place. I'll go through and replace the old icon names with the corresponding new ones.

Did you already do this to make sure the icons don't have a ? in their place? From your latest update,

replace old icon names w/ new icon names (the ones actually from the icon pack)

it looks like you did, but you should probably update the Test Plan too now that it's been done.

atul edited the test plan for this revision. (Show Details)

it looks like you did, but you should probably update the Test Plan too now that it's been done.

Good catch, updated them this morning.

This revision is now accepted and ready to land.Aug 18 2022, 1:20 PM