Page MenuHomePhabricator

[native] make output a static library
ClosedPublic

Authored by varun on Aug 23 2022, 10:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 6, 2:12 AM
Unknown Object (File)
Sun, Oct 6, 2:12 AM
Unknown Object (File)
Sun, Oct 6, 2:12 AM
Unknown Object (File)
Sun, Oct 6, 2:09 AM
Unknown Object (File)
Sep 21 2024, 3:16 PM
Unknown Object (File)
Sep 10 2024, 3:12 AM
Unknown Object (File)
Sep 1 2024, 12:27 PM
Unknown Object (File)
Sep 1 2024, 12:27 PM
Subscribers

Details

Summary

this will make cargo produce a .a file that can be linked in Cmake/Xcode

Test Plan

cargo build, checked target directory for .a file

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek added inline comments.
native/cpp/CommonCpp/grpc/grpc_client/Cargo.toml
26 ↗(On Diff #15900)

Are there any downsides of doing so?

27 ↗(On Diff #15900)

Can we keep a new line?

This revision is now accepted and ready to land.Aug 24 2022, 2:58 AM
native/cpp/CommonCpp/grpc/grpc_client/Cargo.toml
26 ↗(On Diff #15900)

no downsides. the rust lib format doesn't really make sense for us rn. we can add it back if we ever need it.

27 ↗(On Diff #15900)

oh oops yeah

This revision was automatically updated to reflect the committed changes.