Paths

Table of Contentst

Differential D4935

[native] make output a static library
ClosedPublic
Actions

Authored by varun on Aug 23 2022, 10:43 PM.

Tags

None

Referenced Files

	F2166570: D4935.id15900.diff
	Tue, Jul 2, 4:34 AM

	Unknown Object (File)
	Thu, Jun 27, 1:14 AM

	Unknown Object (File)
	Thu, Jun 27, 12:41 AM

	Unknown Object (File)
	Tue, Jun 18, 9:38 AM

	Unknown Object (File)
	Tue, Jun 18, 9:38 AM

	Unknown Object (File)
	Tue, Jun 18, 9:31 AM

	Unknown Object (File)
	Fri, Jun 14, 10:33 PM

	Unknown Object (File)
	May 14 2024, 10:24 AM

View All 42 Files

Subscribers

Details

Reviewers

tomek
• karol
atul

Commits

rCOMMec93d6a29fb8: [native] make output a static library

Summary

this will make cargo produce a .a file that can be linked in Cmake/Xcode

Test Plan

cargo build, checked target directory for .a file

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Aug 23 2022, 10:43 PM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptAug 23 2022, 10:43 PM

varun added a child revision: D4936: [native] restructure functions to be exposed across FFI boundary.Aug 23 2022, 10:44 PM

varun added a parent revision: D4934: [native] change params and types to satisfy cxx requirements.Aug 23 2022, 10:47 PM

Harbormaster completed remote builds in B11564: Diff 15900.Aug 23 2022, 10:53 PM

varun requested review of this revision.Aug 23 2022, 10:53 PM

tomek accepted this revision.Aug 24 2022, 2:58 AM

tomek added inline comments.

native/cpp/CommonCpp/grpc/grpc_client/Cargo.toml
26 ↗	(On Diff #15900)	Are there any downsides of doing so?
27 ↗	(On Diff #15900)	Can we keep a new line?

This revision is now accepted and ready to land.Aug 24 2022, 2:58 AM

varun added inline comments.Aug 25 2022, 3:48 AM

native/cpp/CommonCpp/grpc/grpc_client/Cargo.toml
26 ↗	(On Diff #15900)	no downsides. the rust lib format doesn't really make sense for us rn. we can add it back if we ever need it.
27 ↗	(On Diff #15900)	oh oops yeah

Closed by commit rCOMMec93d6a29fb8: [native] make output a static library (authored by varun). · Explain WhyAug 25 2022, 3:52 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMec93d6a29fb8: [native] make output a static library.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

grpc_client/

3 lines

Diff 15967

native/cpp/CommonCpp/grpc/grpc_client/Cargo.toml

Loading...