Page MenuHomePhabricator

[native] more blocking functions
ClosedPublic

Authored by varun on Aug 23 2022, 10:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 3:21 PM
Unknown Object (File)
Tue, Nov 5, 2:06 AM
Unknown Object (File)
Oct 6 2024, 2:12 AM
Unknown Object (File)
Oct 6 2024, 2:12 AM
Unknown Object (File)
Oct 6 2024, 2:12 AM
Unknown Object (File)
Oct 6 2024, 2:09 AM
Unknown Object (File)
Sep 20 2024, 7:55 PM
Unknown Object (File)
Sep 17 2024, 8:01 PM
Subscribers

Details

Summary

Included all of these functions in a single diff because they all do the same thing - block the tokio runtime on the completion of their equivalent async fns

Depends on D4936

Test Plan

tested in the following diff where we expose these blocking functions in the ffi module

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks ok, but have you considered creating a macro instead of having a couple of functions that do the same thing?

This revision is now accepted and ready to land.Aug 24 2022, 3:16 AM
In D4937#142930, @tomek wrote:

Looks ok, but have you considered creating a macro instead of having a couple of functions that do the same thing?

This is a good idea, I'm just not very experienced writing macros. Added to the improvement task on Linear

This revision was automatically updated to reflect the committed changes.