[native] more blocking functions
ClosedPublic
Actions

Authored by varun on Aug 24 2022, 5:45 AM.

Details

Reviewers

tomek
• karol
atul

Commits

rCOMM9513c6d53357: [native] more blocking functions

Summary

Included all of these functions in a single diff because they all do the same thing - block the tokio runtime on the completion of their equivalent async fns

Depends on D4936

Test Plan

tested in the following diff where we expose these blocking functions in the ffi module

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Aug 24 2022, 5:45 AM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptAug 24 2022, 5:45 AM

varun added a child revision: D4938: [native] expose client functions across FFI boundary.Aug 24 2022, 5:46 AM

Harbormaster completed remote builds in B11566: Diff 15902.Aug 24 2022, 5:55 AM

varun requested review of this revision.Aug 24 2022, 5:55 AM

Looks ok, but have you considered creating a macro instead of having a couple of functions that do the same thing?

This revision is now accepted and ready to land.Aug 24 2022, 10:16 AM

In D4937#142930, @tomek wrote:

Looks ok, but have you considered creating a macro instead of having a couple of functions that do the same thing?

This is a good idea, I'm just not very experienced writing macros. Added to the improvement task on Linear

Closed by commit rCOMM9513c6d53357: [native] more blocking functions. · Explain WhyAug 25 2022, 10:57 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM9513c6d53357: [native] more blocking functions.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

grpc_client/

src/

lib.rs

58 lines

Diff 15969

View Options

native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs

[native] more blocking functionsClosedPublicActions