[web] Unify redux action types variables
ClosedPublic
Actions

Authored by inka on Aug 26 2022, 4:17 AM.

Details

Reviewers

• jakub
• jacek
• abosh
atul
ashoat

Commits

rCOMMf2d3ff5abb01: [web] Unify redux action types variables

Summary

Reordering and renaming of the action types variables on web to help with code readability.
Linear issue: https://linear.app/comm/issue/ENG-1662/unify-action-types-variables-on-web

Test Plan

Checked that web and native can still be launched in dev mode.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Aug 26 2022, 4:17 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 26 2022, 4:17 AM

Harbormaster completed remote builds in B11630: Diff 15996.Aug 26 2022, 4:27 AM

inka requested review of this revision.Aug 26 2022, 4:27 AM

At a high level looks good, but why was updateNavInfoActionType in nav-types to begin with? Is there a difference between a nav type and action type? Or should we keep all "actionable" types together (anything with 'update', 'set', etc.), like in this diff?

Also adding a blocking reviewer so someone else can look at this. Feel free to change blocking status

In D4956#143881, @abosh wrote:

At a high level looks good, but why was updateNavInfoActionType in nav-types to begin with? Is there a difference between a nav type and action type?

No good reason