Page MenuHomePhabricator
Differential D5039

[web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`
ClosedPublic
Actions

Authored by • jacek on Sep 2 2022, 5:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 3:11 AM
Unknown Object (File)
Fri, Mar 28, 4:10 AM
Unknown Object (File)
Fri, Mar 28, 3:35 AM
Unknown Object (File)
Wed, Mar 26, 9:48 PM
Unknown Object (File)
Wed, Mar 26, 1:29 AM
Unknown Object (File)
Wed, Mar 19, 2:09 PM
Unknown Object (File)
Tue, Mar 18, 3:40 PM
Unknown Object (File)
Sun, Mar 16, 1:46 PM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMMd89c8f499c0c: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`
Summary

Follow up: https://phab.comm.dev/D4915#inline-32530

Test Plan

Run web app, confirm that the rename doesn't break tooltip behavior

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jacek created this revision.Sep 2 2022, 5:43 AM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptSep 2 2022, 5:43 AM
• jacek added a parent revision: D5021: [web] Move `tooltip-utils` into `web/utils`.Sep 2 2022, 5:46 AM
Harbormaster completed remote builds in B11839: Diff 16244.Sep 2 2022, 5:53 AM
• jacek requested review of this revision.Sep 2 2022, 5:53 AM
tomek accepted this revision.Sep 2 2022, 6:36 AM
tomek added inline comments.
web/utils/tooltip-utils.js
51–52 ↗(On Diff #16244)

What do you think about having a single structure with x and y props, so that it's more obvious that these are a part of a single entity?

This revision is now accepted and ready to land.Sep 2 2022, 6:36 AM
• jacek added inline comments.Sep 2 2022, 6:46 AM
web/utils/tooltip-utils.js
51–52 ↗(On Diff #16244)

Makes sense

• jacek updated this revision to Diff 16253.Sep 2 2022, 7:47 AM

address feedback

• jacek requested review of this revision.Sep 2 2022, 7:48 AM
• jacek retitled this revision from [web] Rename `x/yCoord` to `x/yAnchorPoint` in `TooltipPositionStyle` to [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`.
Harbormaster completed remote builds in B11848: Diff 16253.Sep 2 2022, 7:57 AM
tomek accepted this revision.Sep 5 2022, 1:14 AM
This revision is now accepted and ready to land.Sep 5 2022, 1:14 AM
Closed by commit rCOMMd89c8f499c0c: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle` (authored by • jacek). · Explain WhySep 5 2022, 3:13 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMMd89c8f499c0c: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`.

Revision Contents
Changeset List

PathSize
web/
chat/
4 lines
utils/
78 lines

Diff 16302

View Options

web/chat/tooltip-provider.js

div.form_title { div.form_title {
padding-top: 6px; padding-top: 6px;
font-size: var(--s-font-14); font-size: var(--s-font-14);
font-weight: 600; font-weight: 600;
} }
span.form_enum_description { div.enum_container {
display: flex; padding: 12px 0;
font-size: var(--xs-font-12);
color: gray;
} }
.save_button { .save_button {
width: 100%; width: 100%;
} }
View Options

web/utils/tooltip-utils.js

div.form_title { div.form_title {
padding-top: 6px; padding-top: 6px;
font-size: var(--s-font-14); font-size: var(--s-font-14);
font-weight: 600; font-weight: 600;
} }
span.form_enum_description { div.enum_container {
display: flex; padding: 12px 0;
font-size: var(--xs-font-12);
color: gray;
} }
.save_button { .save_button {
width: 100%; width: 100%;
} }