Paths

Table of Contentst

Differential D5039

[web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`
ClosedPublic
Actions

Authored by • jacek on Sep 2 2022, 5:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 17, 12:01 PM

	Unknown Object (File)
	Thu, May 9, 5:18 PM

	Unknown Object (File)
	Sun, Apr 28, 11:07 PM

	Unknown Object (File)
	Sun, Apr 28, 11:07 PM

	Unknown Object (File)
	Sun, Apr 28, 11:07 PM

	Unknown Object (File)
	Sun, Apr 28, 11:05 PM

	Unknown Object (File)
	Sun, Apr 28, 10:40 PM

	Unknown Object (File)
	Apr 7 2024, 1:53 AM

View All 72 Files

Subscribers

Details

Reviewers

tomek
atul

Commits

rCOMMd89c8f499c0c: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`

Summary

Follow up: https://phab.comm.dev/D4915#inline-32530

Test Plan

Run web app, confirm that the rename doesn't break tooltip behavior

Diff Detail

Repository

Branch

jacek/message-tooltip-web

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Sep 2 2022, 5:43 AM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptSep 2 2022, 5:43 AM

• jacek added a parent revision: D5021: [web] Move `tooltip-utils` into `web/utils`.Sep 2 2022, 5:46 AM

Harbormaster completed remote builds in B11839: Diff 16244.Sep 2 2022, 5:53 AM

• jacek requested review of this revision.Sep 2 2022, 5:53 AM

tomek accepted this revision.Sep 2 2022, 6:36 AM

tomek added inline comments.

web/utils/tooltip-utils.js
51–52 ↗	(On Diff #16244)	What do you think about having a single structure with `x` and `y` props, so that it's more obvious that these are a part of a single entity?

This revision is now accepted and ready to land.Sep 2 2022, 6:36 AM

• jacek added inline comments.Sep 2 2022, 6:46 AM

web/utils/tooltip-utils.js
51–52 ↗	(On Diff #16244)	Makes sense

address feedback

• jacek requested review of this revision.Sep 2 2022, 7:48 AM

• jacek retitled this revision from [web] Rename `x/yCoord` to `x/yAnchorPoint` in `TooltipPositionStyle` to [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`.

Harbormaster completed remote builds in B11848: Diff 16253.Sep 2 2022, 7:57 AM

tomek accepted this revision.Sep 5 2022, 1:14 AM

This revision is now accepted and ready to land.Sep 5 2022, 1:14 AM

Closed by commit rCOMMd89c8f499c0c: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle` (authored by • jacek). · Explain WhySep 5 2022, 3:13 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMMd89c8f499c0c: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`.

Revision Contents
Changeset List

Path

Size

web/

chat/

tooltip-provider.js

4 lines

utils/

tooltip-utils.js

78 lines

Diff 16253

web/chat/tooltip-provider.js

Loading...

web/utils/tooltip-utils.js

Loading...