Page MenuHomePhabricator

[Nix] Fix corrosion usage with nix develop
AbandonedPublic

Authored by jon on Sep 2 2022, 5:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 26 2024, 2:15 AM
Unknown Object (File)
Oct 26 2024, 2:15 AM
Unknown Object (File)
Oct 26 2024, 2:15 AM
Unknown Object (File)
Oct 26 2024, 2:11 AM
Unknown Object (File)
Oct 23 2024, 10:06 AM
Unknown Object (File)
Oct 23 2024, 10:06 AM
Unknown Object (File)
Oct 17 2024, 11:13 PM
Unknown Object (File)
Oct 16 2024, 11:36 PM
Subscribers

Details

Reviewers
atul
abosh
varun
max
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Services which were using corrosion were
failing to build with nix develop.

This updates corrosion to include fixes found in
https://github.com/corrosion-rs/corrosion/pull/192

Related:

Test Plan
nix develop
# services
cd services/tunnelbroker
rm -rf build && mkdir build && cd build && cmake .. && make -j

# close any existing xcode sessions
open -na xcode
# run xcode build

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Owners added a reviewer: Restricted Owners Package.Sep 2 2022, 5:10 PM
atul requested changes to this revision.Sep 6 2022, 12:59 AM

Hmm, running into the following when I follow the Test Plan:

/Users/atul/comm/services/tunnelbroker/build/protos/tunnelbroker.pb.cc:2392:12: error: no member named 'Swap' in 'google::protobuf::internal::ArenaStringPtr'
  payload_.Swap(&other->payload_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());
  ~~~~~~~~ ^
/Users/atul/comm/services/tunnelbroker/build/protos/tunnelbroker.pb.cc:2902:14: error: no member named 'Swap' in 'google::protobuf::internal::ArenaStringPtr'
  messageid_.Swap(&other->messageid_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());
  ~~~~~~~~~~ ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [protos/CMakeFiles/comm-tunnelbroker-grpc.dir/tunnelbroker.pb.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....

Looks like I have the right version of protoc

atuls-MacBook-Pro:build atul$ which protoc
/nix/store/r5nv2l4hiraggzawpjhxhbqgnc93p0a9-protobuf-3.15.8/bin/protoc
This revision now requires changes to proceed.Sep 6 2022, 12:59 AM
jon requested review of this revision.EditedSep 6 2022, 9:15 AM

@atul did you remove the old build folder?

I'm able to build this by either checking out the commit, or by doing arc patch D5041 from master

This should no longer be necessary after https://phab.comm.dev/D5077