Page MenuHomePhabricator

[Services] Update tunnelbroker reference to protos
ClosedPublic

Authored by jon on Sep 2 2022, 5:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 14, 11:27 AM
Unknown Object (File)
Tue, May 14, 11:27 AM
Unknown Object (File)
Tue, May 14, 11:27 AM
Unknown Object (File)
Tue, May 14, 11:27 AM
Unknown Object (File)
Tue, May 14, 11:23 AM
Unknown Object (File)
Mon, May 13, 5:21 PM
Unknown Object (File)
Thu, May 9, 5:19 PM
Unknown Object (File)
Thu, May 9, 5:19 PM
Subscribers

Details

Summary

Update tunnelbroker build to
reference new protobuf location.

https://linear.app/comm/issue/ENG-1231

Depends on D5041 D4992

Test Plan
nix develop
cd services/tunnelbroker
rm -rf build && mkdir build && cd build && cmake .. && make -j

Existing tunnelbroker CI gate

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested changes to this revision.Sep 6 2022, 1:01 AM

Running into the same issue when I try following the Test Plan:

/Users/atul/comm/services/tunnelbroker/build/protos/tunnelbroker.pb.cc:2122:14: error: no member named 'Swap' in 'google::protobuf::internal::ArenaStringPtr'
   Compiling futures-task v0.3.21
  sessionid_.Swap(&other->sessionid_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());
  ~~~~~~~~~~ ^
/Users/atul/comm/services/tunnelbroker/build/protos/tunnelbroker.pb.cc:2391:17: error: no member named 'Swap' in 'google::protobuf::internal::ArenaStringPtr'
  fromdeviceid_.Swap(&other->fromdeviceid_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());
  ~~~~~~~~~~~~~ ^
/Users/atul/comm/services/tunnelbroker/build/protos/tunnelbroker.pb.cc:2392:12: error: no member named 'Swap' in 'google::protobuf::internal::ArenaStringPtr'
  payload_.Swap(&other->payload_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());
  ~~~~~~~~ ^
/Users/atul/comm/services/tunnelbroker/build/protos/tunnelbroker.pb.cc:2902:14: error: no member named 'Swap' in 'google::protobuf::internal::ArenaStringPtr'
  messageid_.Swap(&other->messageid_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());
  ~~~~~~~~~~ ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]

Let me know if I'm missing something

This revision now requires changes to proceed.Sep 6 2022, 1:01 AM

Was able to follow Test Plan in macOS VM:

Screen Shot 2022-09-07 at 8.02.57 PM.png (1×2 px, 1 MB)

This revision is now accepted and ready to land.Sep 7 2022, 5:03 PM