Page MenuHomePhabricator
Differential D5044

[Services] Update docker references to protobuf
ClosedPublic
Actions

Authored by • jon on Sep 2 2022, 5:24 PM.
Tags
None
Referenced Files
F5073463: D5044.id16277.diff
Fri, Mar 28, 7:10 AM
Unknown Object (File)
Wed, Mar 26, 1:30 AM
Unknown Object (File)
Wed, Mar 26, 1:30 AM
Unknown Object (File)
Wed, Mar 26, 1:30 AM
Unknown Object (File)
Wed, Mar 26, 1:30 AM
Unknown Object (File)
Wed, Mar 26, 1:30 AM
Unknown Object (File)
Tue, Mar 25, 5:44 PM
Unknown Object (File)
Mon, Mar 24, 9:31 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
• max
• abosh
• karol
Commits
rCOMMa679857502c6: [Services] Update docker references to protobuf
Summary

Update docker files to reference new
protobuf file locations.

part of: https://linear.app/comm/issue/ENG-1231

Test Plan

backup, tunnelbroker, and blob gates pass

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Sep 2 2022, 5:24 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 2 2022, 5:24 PM
• jon updated this revision to Diff 16274.Sep 2 2022, 5:26 PM

Rebase

Harbormaster failed remote builds in B11860: Diff 16273!Sep 2 2022, 5:27 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 2 2022, 5:29 PM
Harbormaster failed remote builds in B11861: Diff 16274!
• jon added a child revision: D5046: [Native] Remove old protos and related files.Sep 2 2022, 5:41 PM
• jon updated this revision to Diff 16277.Sep 2 2022, 5:56 PM

Have backup docker add grpc files similarly to others

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 2 2022, 5:57 PM
Harbormaster failed remote builds in B11864: Diff 16277!
• jon updated this revision to Diff 16278.Sep 2 2022, 6:10 PM

Adjust build.rs

Harbormaster completed remote builds in B11865: Diff 16278.Sep 2 2022, 6:20 PM
• jon requested review of this revision.Sep 2 2022, 6:20 PM
atul accepted this revision.Sep 6 2022, 1:05 AM
This revision is now accepted and ready to land.Sep 6 2022, 1:05 AM
• jon edited the summary of this revision. (Show Details)Sep 6 2022, 7:32 AM
• jon added a parent revision: D4992: [Shared] Copy protos to shared/protos, adjust CMake.Sep 6 2022, 9:12 AM
• jon mentioned this in D4998: [Services] Update blob to reference new directory.Sep 6 2022, 10:17 AM
• jon updated this revision to Diff 16424.Sep 7 2022, 9:46 AM

Rebase on master

Harbormaster completed remote builds in B11970: Diff 16424.Sep 7 2022, 9:57 AM
Closed by commit rCOMMa679857502c6: [Services] Update docker references to protobuf (authored by • jon). · Explain WhySep 8 2022, 10:30 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMa679857502c6: [Services] Update docker references to protobuf.

Revision Contents
Changeset List

PathSize
services/
backup/
2 lines
blob_client/
2 lines
blob/
2 lines
identity/
2 lines
tunnelbroker/
2 lines

Diff 16512

View Options

services/backup/Dockerfile

Show All 12 Lines
WORKDIR /transferred/backup WORKDIR /transferred/backup
COPY services/lib/docker/ scripts/ COPY services/lib/docker/ scripts/
# install rust # install rust
RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
RUN scripts/install_corrosion.sh RUN scripts/install_corrosion.sh
COPY native/cpp/CommonCpp/grpc grpc/ ADD shared/protos grpc
COPY shared/cmake cmake-components/ COPY shared/cmake cmake-components/
COPY services/backup/ /transferred/backup/ COPY services/backup/ /transferred/backup/
COPY services/lib/src/ /transferred/lib/src/ COPY services/lib/src/ /transferred/lib/src/
RUN scripts/build_service.sh RUN scripts/build_service.sh
CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_service.sh; fi CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_service.sh; fi
View Options

services/backup/blob_client/build.rs

Loading...
View Options

services/blob/Dockerfile

Show All 12 Lines
WORKDIR /transferred WORKDIR /transferred
COPY services/lib/docker/ scripts/ COPY services/lib/docker/ scripts/
COPY services/blob/ blob COPY services/blob/ blob
COPY services/lib/src lib/src/ COPY services/lib/src lib/src/
WORKDIR /transferred/blob WORKDIR /transferred/blob
ADD native/cpp/CommonCpp/grpc grpc ADD shared/protos grpc
RUN ../scripts/build_service.sh RUN ../scripts/build_service.sh
CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then ../scripts/run_tests.sh; else ../scripts/run_service.sh; fi CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then ../scripts/run_tests.sh; else ../scripts/run_service.sh; fi
View Options

services/identity/Dockerfile

Loading...
View Options

services/tunnelbroker/Dockerfile

Loading...