Page MenuHomePhabricator
Differential D4996

[Chore] Update Podfile.lock
AbandonedPublic
Actions

Authored by • jon on Aug 31 2022, 10:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 5:57 AM
Unknown Object (File)
Sat, Nov 9, 11:39 AM
Unknown Object (File)
Sat, Nov 9, 11:06 AM
Unknown Object (File)
Sat, Nov 9, 7:21 AM
Unknown Object (File)
Wed, Oct 23, 10:03 AM
Unknown Object (File)
Mon, Oct 21, 5:58 PM
Unknown Object (File)
Thu, Oct 17, 10:49 AM
Unknown Object (File)
Sep 27 2024, 2:08 AM
View All 79 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
varun
• abosh
Summary

XCode build failed for me withouto this update

Depends on D4995

Test Plan

iOS CI passes

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 31 2022, 10:35 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 31 2022, 10:35 AM
Harbormaster completed remote builds in B11739: Diff 16130.Aug 31 2022, 10:45 AM
• jon requested review of this revision.Aug 31 2022, 10:45 AM
• jon added a child revision: D4998: [Services] Update blob to reference new directory.Aug 31 2022, 11:11 AM
atul requested changes to this revision.Aug 31 2022, 10:36 PM

Hm, can you try rebasing off of master and seeing if these changes are still necessary?

I rebased, patched this diff, ran pod install, and got the following:

diff --git a/native/ios/Podfile.lock b/native/ios/Podfile.lock
index 91a4369be..9a03cfdb8 100644
--- a/native/ios/Podfile.lock
+++ b/native/ios/Podfile.lock
@@ -770,6 +770,8 @@ PODS:
     - React-Core
     - react-native-video/Video
     - SPTPersistentCache (~> 1.1.0)
+  - react-native-webview (11.23.0):
+    - React-Core
   - React-perflogger (0.66.4)
   - React-RCTActionSheet (0.66.4):
     - React-Core/RCTActionSheetHeaders (= 0.66.4)
@@ -992,6 +994,7 @@ DEPENDENCIES:
   - react-native-orientation-locker (from `../../node_modules/react-native-orientation-locker`)
   - react-native-safe-area-context (from `../../node_modules/react-native-safe-area-context`)
   - react-native-video/VideoCaching (from `../../node_modules/react-native-video/react-native-video.podspec`)
+  - react-native-webview (from `../../node_modules/react-native-webview`)
   - React-perflogger (from `../../node_modules/react-native/ReactCommon/reactperflogger`)
   - React-RCTActionSheet (from `../../node_modules/react-native/Libraries/ActionSheetIOS`)
   - React-RCTAnimation (from `../../node_modules/react-native/Libraries/NativeAnimation`)
@@ -1143,6 +1146,8 @@ EXTERNAL SOURCES:
     :path: "../../node_modules/react-native-safe-area-context"
   react-native-video:
     :podspec: "../../node_modules/react-native-video/react-native-video.podspec"
+  react-native-webview:
+    :path: "../../node_modules/react-native-webview"
   React-perflogger:
     :path: "../../node_modules/react-native/ReactCommon/reactperflogger"
   React-RCTActionSheet:
@@ -1272,6 +1277,7 @@ SPEC CHECKSUMS:
   react-native-orientation-locker: 23918c400376a7043e752c639c122fcf6bce8f1c
   react-native-safe-area-context: b6e0e284002381d2ff29fa4fff42b4d8282e3c94
   react-native-video: 0bb76b6d6b77da3009611586c7dbf817b947f30e
+  react-native-webview: e771bc375f789ebfa02a26939a57dbc6fa897336
   React-perflogger: 93075d8931c32cd1fce8a98c15d2d5ccc4d891bd
   React-RCTActionSheet: 7d3041e6761b4f3044a37079ddcb156575fb6d89
   React-RCTAnimation: 743e88b55ac62511ae5c2e22803d4f503f2a3a13

which indicates to me that we do want react-native-webview listed in Podfile.lock?

This revision now requires changes to proceed.Aug 31 2022, 10:36 PM
• jon abandoned this revision.Sep 1 2022, 10:56 AM

interesting. I will likely just abandon diff. I was able to produce the iOS revision I needed

Revision Contents
Changeset List

PathSize
native/
ios/
6 lines

Diff 16130

View Options

native/ios/Podfile.lock

Loading...