Page MenuHomePhabricator
Differential D4995

[iOS] Update xcode to point to new proto location
ClosedPublic
Actions

Authored by • jon on Aug 31 2022, 10:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 16, 8:49 AM
Unknown Object (File)
Mon, May 13, 5:20 PM
Unknown Object (File)
Mon, May 13, 2:52 PM
Unknown Object (File)
Thu, May 9, 5:16 PM
Unknown Object (File)
Thu, May 9, 5:16 PM
Unknown Object (File)
Thu, May 9, 5:16 PM
Unknown Object (File)
Thu, May 9, 5:16 PM
Unknown Object (File)
Wed, May 1, 11:59 AM
View All 85 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
varun
• abosh
Commits
rCOMMac422d78096f: [iOS] Update xcode to point to new proto location
Summary

Update xcode project to reference new protobuff files

https://linear.app/comm/issue/ENG-1231

Depends on D4994

Test Plan

iOS CI passes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Aug 31 2022, 10:34 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 31 2022, 10:34 AM
• jon added a child revision: D4996: [Chore] Update Podfile.lock.Aug 31 2022, 10:35 AM
Harbormaster completed remote builds in B11738: Diff 16129.Aug 31 2022, 10:44 AM
• jon requested review of this revision.Aug 31 2022, 10:44 AM
atul accepted this revision.Aug 31 2022, 10:30 PM

Looks good!

Patched in this diff and made sure that everything built and showed up in Xcode as expected

This revision is now accepted and ready to land.Aug 31 2022, 10:30 PM
• jon updated this revision to Diff 16268.Sep 2 2022, 3:27 PM

Rebase on top of master

Harbormaster completed remote builds in B11855: Diff 16268.Sep 2 2022, 3:37 PM
• jon added a child revision: D5046: [Native] Remove old protos and related files.Sep 2 2022, 5:41 PM
• jon updated this revision to Diff 16419.Sep 7 2022, 9:41 AM

Rebase on master

Harbormaster completed remote builds in B11965: Diff 16419.Sep 7 2022, 9:52 AM
Closed by commit rCOMMac422d78096f: [iOS] Update xcode to point to new proto location (authored by • jon). · Explain WhySep 8 2022, 10:29 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMac422d78096f: [iOS] Update xcode to point to new proto location.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
65 lines

Diff 16508

View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...