Page MenuHomePhabricator
Differential D5046

[Native] Remove old protos and related files
ClosedPublic
Actions

Authored by • jon on Sep 2 2022, 5:41 PM.
Tags
None
Referenced Files
F5074801: D5046.id16276.diff
Fri, Mar 28, 1:21 PM
Unknown Object (File)
Tue, Mar 25, 2:42 AM
Unknown Object (File)
Fri, Mar 21, 5:45 PM
Unknown Object (File)
Wed, Mar 19, 1:53 PM
Unknown Object (File)
Tue, Mar 18, 2:15 PM
Unknown Object (File)
Sat, Mar 15, 12:48 PM
Unknown Object (File)
Thu, Mar 13, 1:37 AM
Unknown Object (File)
Wed, Mar 12, 10:07 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
• abosh
varun
• max
Commits
rCOMM83e7e359cad8: [Native] Remove old protos and related files
Summary

Remove old protobuf files now that
all references have been updated.

https://linear.app/comm/issue/ENG-1231

Depends on D5045 D5044 D5043 D5042 D4998 D5041 D4995 D4994 D4993 D4992

Test Plan

CI gates pass

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Sep 2 2022, 5:41 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 2 2022, 5:41 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 2 2022, 5:46 PM
Harbormaster failed remote builds in B11863: Diff 16276!
• jon updated this revision to Diff 16280.Sep 2 2022, 6:20 PM

Rebase with backup fixes

• jon retitled this revision from [Native] Remove protos and related files to [Native] Remove old protos and related files.Sep 2 2022, 6:23 PM
Harbormaster completed remote builds in B11867: Diff 16280.Sep 2 2022, 6:30 PM
• jon requested review of this revision.Sep 2 2022, 6:30 PM
• jon edited the summary of this revision. (Show Details)Sep 6 2022, 7:33 AM
atul accepted this revision.Sep 7 2022, 8:32 AM
This revision is now accepted and ready to land.Sep 7 2022, 8:32 AM
• jon updated this revision to Diff 16426.Sep 7 2022, 9:46 AM

Rebase on master

• jon removed a parent revision: D5041: [Nix] Fix corrosion usage with nix develop.Sep 7 2022, 9:56 AM
Harbormaster completed remote builds in B11972: Diff 16426.Sep 7 2022, 9:58 AM
Closed by commit rCOMM83e7e359cad8: [Native] Remove old protos and related files (authored by • jon). · Explain WhySep 8 2022, 10:30 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM83e7e359cad8: [Native] Remove old protos and related files.
• jon mentioned this in D5102: [Services] Update commtest protobuf location.Sep 9 2022, 12:11 PM
• jon mentioned this in rCOMM0fe62495322b: [Services] Update commtest protobuf location.Sep 12 2022, 10:50 AM

Revision Contents
Changeset List

Diff 16514

View Options

native/cpp/CommonCpp/grpc/_generated/.clang-format

Show All 37 Lines
) )
if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker") if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker")
# Inside the docker build contex # Inside the docker build contex
set(_proto_path "grpc") set(_proto_path "grpc")
set(_shared_path "../shared") set(_shared_path "../shared")
else() else()
# Inside repo # Inside repo
set(_proto_path "../../native/cpp/CommonCpp/grpc")
set(_shared_path "../../shared") set(_shared_path "../../shared")
set(_proto_path "../../shared/protos")
endif() endif()
# Shared Comm protos # Shared Comm protos
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path} add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path}
${CMAKE_CURRENT_BINARY_DIR}/protos ${CMAKE_CURRENT_BINARY_DIR}/protos
EXCLUDE_FROM_ALL EXCLUDE_FROM_ALL
) )
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/grpc/_generated/backup.grpc.pb.h

Show All 37 Lines
) )
if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker") if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker")
# Inside the docker build contex # Inside the docker build contex
set(_proto_path "grpc") set(_proto_path "grpc")
set(_shared_path "../shared") set(_shared_path "../shared")
else() else()
# Inside repo # Inside repo
set(_proto_path "../../native/cpp/CommonCpp/grpc")
set(_shared_path "../../shared") set(_shared_path "../../shared")
set(_proto_path "../../shared/protos")
endif() endif()
# Shared Comm protos # Shared Comm protos
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path} add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path}
${CMAKE_CURRENT_BINARY_DIR}/protos ${CMAKE_CURRENT_BINARY_DIR}/protos
EXCLUDE_FROM_ALL EXCLUDE_FROM_ALL
) )
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/grpc/_generated/backup.grpc.pb.cc

Show All 37 Lines
) )
if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker") if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker")
# Inside the docker build contex # Inside the docker build contex
set(_proto_path "grpc") set(_proto_path "grpc")
set(_shared_path "../shared") set(_shared_path "../shared")
else() else()
# Inside repo # Inside repo
set(_proto_path "../../native/cpp/CommonCpp/grpc")
set(_shared_path "../../shared") set(_shared_path "../../shared")
set(_proto_path "../../shared/protos")
endif() endif()
# Shared Comm protos # Shared Comm protos
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path} add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path}
${CMAKE_CURRENT_BINARY_DIR}/protos ${CMAKE_CURRENT_BINARY_DIR}/protos
EXCLUDE_FROM_ALL EXCLUDE_FROM_ALL
) )
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/grpc/_generated/backup.pb.h

Show All 37 Lines
) )
if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker") if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker")
# Inside the docker build contex # Inside the docker build contex
set(_proto_path "grpc") set(_proto_path "grpc")
set(_shared_path "../shared") set(_shared_path "../shared")
else() else()
# Inside repo # Inside repo
set(_proto_path "../../native/cpp/CommonCpp/grpc")
set(_shared_path "../../shared") set(_shared_path "../../shared")
set(_proto_path "../../shared/protos")
endif() endif()
# Shared Comm protos # Shared Comm protos
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path} add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path}
${CMAKE_CURRENT_BINARY_DIR}/protos ${CMAKE_CURRENT_BINARY_DIR}/protos
EXCLUDE_FROM_ALL EXCLUDE_FROM_ALL
) )
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/grpc/_generated/backup.pb.cc

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/blob.grpc.pb.h

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/blob.grpc.pb.cc

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/blob.pb.h

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/blob.pb.cc

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.h

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.cc

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.pb.h

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.pb.cc

Loading...
View Options

native/cpp/CommonCpp/grpc/protos/backup.proto

Loading...
View Options

native/cpp/CommonCpp/grpc/protos/blob.proto

Loading...
View Options

native/cpp/CommonCpp/grpc/protos/identity.proto

Loading...
View Options

native/cpp/CommonCpp/grpc/protos/tunnelbroker.proto

Loading...