Page MenuHomePhabricator
Differential D5044

[Services] Update docker references to protobuf
ClosedPublic
Actions

Authored by • jon on Sep 2 2022, 5:24 PM.
Tags
None
Referenced Files
F5119913: D5044.id16274.diff
Thu, Apr 3, 5:11 AM
Unknown Object (File)
Tue, Apr 1, 10:35 AM
Unknown Object (File)
Tue, Apr 1, 10:35 AM
Unknown Object (File)
Tue, Apr 1, 10:35 AM
Unknown Object (File)
Tue, Apr 1, 10:35 AM
Unknown Object (File)
Tue, Apr 1, 10:35 AM
Unknown Object (File)
Tue, Apr 1, 10:35 AM
Unknown Object (File)
Mon, Mar 31, 2:36 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
• max
• abosh
• karol
Commits
rCOMMa679857502c6: [Services] Update docker references to protobuf
Summary

Update docker files to reference new
protobuf file locations.

part of: https://linear.app/comm/issue/ENG-1231

Test Plan

backup, tunnelbroker, and blob gates pass

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Sep 2 2022, 5:24 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 2 2022, 5:24 PM
• jon updated this revision to Diff 16274.Sep 2 2022, 5:26 PM

Rebase

Harbormaster failed remote builds in B11860: Diff 16273!Sep 2 2022, 5:27 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 2 2022, 5:29 PM
Harbormaster failed remote builds in B11861: Diff 16274!
• jon added a child revision: D5046: [Native] Remove old protos and related files.Sep 2 2022, 5:41 PM
• jon updated this revision to Diff 16277.Sep 2 2022, 5:56 PM

Have backup docker add grpc files similarly to others

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 2 2022, 5:57 PM
Harbormaster failed remote builds in B11864: Diff 16277!
• jon updated this revision to Diff 16278.Sep 2 2022, 6:10 PM

Adjust build.rs

Harbormaster completed remote builds in B11865: Diff 16278.Sep 2 2022, 6:20 PM
• jon requested review of this revision.Sep 2 2022, 6:20 PM
atul accepted this revision.Sep 6 2022, 1:05 AM
This revision is now accepted and ready to land.Sep 6 2022, 1:05 AM
• jon edited the summary of this revision. (Show Details)Sep 6 2022, 7:32 AM
• jon added a parent revision: D4992: [Shared] Copy protos to shared/protos, adjust CMake.Sep 6 2022, 9:12 AM
• jon mentioned this in D4998: [Services] Update blob to reference new directory.Sep 6 2022, 10:17 AM
• jon updated this revision to Diff 16424.Sep 7 2022, 9:46 AM

Rebase on master

Harbormaster completed remote builds in B11970: Diff 16424.Sep 7 2022, 9:57 AM
Closed by commit rCOMMa679857502c6: [Services] Update docker references to protobuf (authored by • jon). · Explain WhySep 8 2022, 10:30 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMa679857502c6: [Services] Update docker references to protobuf.

Revision Contents
Changeset List

PathSize
services/
backup/
2 lines
blob/
2 lines
identity/
2 lines
tunnelbroker/
2 lines

Diff 16277

View Options

services/backup/Dockerfile

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Linesimport type {
EventSubscription, EventSubscription,
KeyboardEvent, KeyboardEvent,
} from '../types/react-native.js'; } from '../types/react-native.js';
import type { ImageStyle } from '../types/styles.js'; import type { ImageStyle } from '../types/styles.js';
import { import {
runTiming, runTiming,
ratchetAlongWithKeyboardHeight, ratchetAlongWithKeyboardHeight,
} from '../utils/animation-utils.js'; } from '../utils/animation-utils.js';
import { useInitialNotificationsEncryptedMessage } from '../utils/crypto-utils.js';
import { import {
type StateContainer, type StateContainer,
type StateChange, type StateChange,
setStateForContainer, setStateForContainer,
} from '../utils/state-container.js'; } from '../utils/state-container.js';
import EthereumLogo from '../vectors/ethereum-logo.react.js'; import EthereumLogo from '../vectors/ethereum-logo.react.js';
let initialAppLoad = true; let initialAppLoad = true;
▲ Show 20 Lines • Show All 58 Lines • ▼ Show 20 Linestype Props = {
+cookie: ?string, +cookie: ?string,
+urlPrefix: string, +urlPrefix: string,
+loggedIn: boolean, +loggedIn: boolean,
+dimensions: DerivedDimensionsInfo, +dimensions: DerivedDimensionsInfo,
+splashStyle: ImageStyle, +splashStyle: ImageStyle,
+styles: typeof unboundStyles, +styles: typeof unboundStyles,
// Redux dispatch functions // Redux dispatch functions
+dispatch: Dispatch, +dispatch: Dispatch,
// Keyserver olm sessions functions
+initialNotificationsEncryptedMessage: () => Promise<string>,
}; };
type State = { type State = {
+mode: LoggedOutMode, +mode: LoggedOutMode,
+nextMode: LoggedOutMode, +nextMode: LoggedOutMode,
+logInState: StateContainer<LogInState>, +logInState: StateContainer<LogInState>,
+registerState: StateContainer<RegisterState>, +registerState: StateContainer<RegisterState>,
}; };
class LoggedOutModal extends React.PureComponent<Props, State> { class LoggedOutModal extends React.PureComponent<Props, State> {
▲ Show 20 Lines • Show All 163 Lines • ▼ Show 20 Lines if (!__DEV__) {
const actionSource = loggedIn const actionSource = loggedIn
? logInActionSources.appStartReduxLoggedInButInvalidCookie ? logInActionSources.appStartReduxLoggedInButInvalidCookie
: logInActionSources.appStartCookieLoggedInButInvalidRedux; : logInActionSources.appStartCookieLoggedInButInvalidRedux;
const sessionChange = await fetchNewCookieFromNativeCredentials( const sessionChange = await fetchNewCookieFromNativeCredentials(
dispatch, dispatch,
cookie, cookie,
urlPrefix, urlPrefix,
actionSource, actionSource,
this.props.initialNotificationsEncryptedMessage,
); );
if ( if (
sessionChange && sessionChange &&
sessionChange.cookie && sessionChange.cookie &&
sessionChange.cookie.startsWith('user=') sessionChange.cookie.startsWith('user=')
) { ) {
// success! we can expect subsequent actions to fix up the state // success! we can expect subsequent actions to fix up the state
return; return;
▲ Show 20 Lines • Show All 447 Lines • ▼ Show 20 Lines React.memo<BaseProps>(function ConnectedLoggedOutModal(props: BaseProps) {
const cookie = useSelector(state => state.cookie); const cookie = useSelector(state => state.cookie);
const urlPrefix = useSelector(state => state.urlPrefix); const urlPrefix = useSelector(state => state.urlPrefix);
const loggedIn = useSelector(isLoggedIn); const loggedIn = useSelector(isLoggedIn);
const dimensions = useSelector(derivedDimensionsInfoSelector); const dimensions = useSelector(derivedDimensionsInfoSelector);
const splashStyle = useSelector(splashStyleSelector); const splashStyle = useSelector(splashStyleSelector);
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatch = useDispatch(); const dispatch = useDispatch();
const callInitialNotificationsEncryptedMessage =
useInitialNotificationsEncryptedMessage();
return ( return (
<LoggedOutModal <LoggedOutModal
{...props} {...props}
isForeground={isForeground} isForeground={isForeground}
persistedStateLoaded={persistedStateLoaded} persistedStateLoaded={persistedStateLoaded}
rehydrateConcluded={rehydrateConcluded} rehydrateConcluded={rehydrateConcluded}
cookie={cookie} cookie={cookie}
urlPrefix={urlPrefix} urlPrefix={urlPrefix}
loggedIn={loggedIn} loggedIn={loggedIn}
dimensions={dimensions} dimensions={dimensions}
splashStyle={splashStyle} splashStyle={splashStyle}
styles={styles} styles={styles}
dispatch={dispatch} dispatch={dispatch}
initialNotificationsEncryptedMessage={
callInitialNotificationsEncryptedMessage
}
/> />
); );
}); });
export default ConnectedLoggedOutModal; export default ConnectedLoggedOutModal;
View Options

services/blob/Dockerfile

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Linesimport type {
EventSubscription, EventSubscription,
KeyboardEvent, KeyboardEvent,
} from '../types/react-native.js'; } from '../types/react-native.js';
import type { ImageStyle } from '../types/styles.js'; import type { ImageStyle } from '../types/styles.js';
import { import {
runTiming, runTiming,
ratchetAlongWithKeyboardHeight, ratchetAlongWithKeyboardHeight,
} from '../utils/animation-utils.js'; } from '../utils/animation-utils.js';
import { useInitialNotificationsEncryptedMessage } from '../utils/crypto-utils.js';
import { import {
type StateContainer, type StateContainer,
type StateChange, type StateChange,
setStateForContainer, setStateForContainer,
} from '../utils/state-container.js'; } from '../utils/state-container.js';
import EthereumLogo from '../vectors/ethereum-logo.react.js'; import EthereumLogo from '../vectors/ethereum-logo.react.js';
let initialAppLoad = true; let initialAppLoad = true;
▲ Show 20 Lines • Show All 58 Lines • ▼ Show 20 Linestype Props = {
+cookie: ?string, +cookie: ?string,
+urlPrefix: string, +urlPrefix: string,
+loggedIn: boolean, +loggedIn: boolean,
+dimensions: DerivedDimensionsInfo, +dimensions: DerivedDimensionsInfo,
+splashStyle: ImageStyle, +splashStyle: ImageStyle,
+styles: typeof unboundStyles, +styles: typeof unboundStyles,
// Redux dispatch functions // Redux dispatch functions
+dispatch: Dispatch, +dispatch: Dispatch,
// Keyserver olm sessions functions
+initialNotificationsEncryptedMessage: () => Promise<string>,
}; };
type State = { type State = {
+mode: LoggedOutMode, +mode: LoggedOutMode,
+nextMode: LoggedOutMode, +nextMode: LoggedOutMode,
+logInState: StateContainer<LogInState>, +logInState: StateContainer<LogInState>,
+registerState: StateContainer<RegisterState>, +registerState: StateContainer<RegisterState>,
}; };
class LoggedOutModal extends React.PureComponent<Props, State> { class LoggedOutModal extends React.PureComponent<Props, State> {
▲ Show 20 Lines • Show All 163 Lines • ▼ Show 20 Lines if (!__DEV__) {
const actionSource = loggedIn const actionSource = loggedIn
? logInActionSources.appStartReduxLoggedInButInvalidCookie ? logInActionSources.appStartReduxLoggedInButInvalidCookie
: logInActionSources.appStartCookieLoggedInButInvalidRedux; : logInActionSources.appStartCookieLoggedInButInvalidRedux;
const sessionChange = await fetchNewCookieFromNativeCredentials( const sessionChange = await fetchNewCookieFromNativeCredentials(
dispatch, dispatch,
cookie, cookie,
urlPrefix, urlPrefix,
actionSource, actionSource,
this.props.initialNotificationsEncryptedMessage,
); );
if ( if (
sessionChange && sessionChange &&
sessionChange.cookie && sessionChange.cookie &&
sessionChange.cookie.startsWith('user=') sessionChange.cookie.startsWith('user=')
) { ) {
// success! we can expect subsequent actions to fix up the state // success! we can expect subsequent actions to fix up the state
return; return;
▲ Show 20 Lines • Show All 447 Lines • ▼ Show 20 Lines React.memo<BaseProps>(function ConnectedLoggedOutModal(props: BaseProps) {
const cookie = useSelector(state => state.cookie); const cookie = useSelector(state => state.cookie);
const urlPrefix = useSelector(state => state.urlPrefix); const urlPrefix = useSelector(state => state.urlPrefix);
const loggedIn = useSelector(isLoggedIn); const loggedIn = useSelector(isLoggedIn);
const dimensions = useSelector(derivedDimensionsInfoSelector); const dimensions = useSelector(derivedDimensionsInfoSelector);
const splashStyle = useSelector(splashStyleSelector); const splashStyle = useSelector(splashStyleSelector);
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatch = useDispatch(); const dispatch = useDispatch();
const callInitialNotificationsEncryptedMessage =
useInitialNotificationsEncryptedMessage();
return ( return (
<LoggedOutModal <LoggedOutModal
{...props} {...props}
isForeground={isForeground} isForeground={isForeground}
persistedStateLoaded={persistedStateLoaded} persistedStateLoaded={persistedStateLoaded}
rehydrateConcluded={rehydrateConcluded} rehydrateConcluded={rehydrateConcluded}
cookie={cookie} cookie={cookie}
urlPrefix={urlPrefix} urlPrefix={urlPrefix}
loggedIn={loggedIn} loggedIn={loggedIn}
dimensions={dimensions} dimensions={dimensions}
splashStyle={splashStyle} splashStyle={splashStyle}
styles={styles} styles={styles}
dispatch={dispatch} dispatch={dispatch}
initialNotificationsEncryptedMessage={
callInitialNotificationsEncryptedMessage
}
/> />
); );
}); });
export default ConnectedLoggedOutModal; export default ConnectedLoggedOutModal;
View Options

services/identity/Dockerfile

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Linesimport type {
EventSubscription, EventSubscription,
KeyboardEvent, KeyboardEvent,
} from '../types/react-native.js'; } from '../types/react-native.js';
import type { ImageStyle } from '../types/styles.js'; import type { ImageStyle } from '../types/styles.js';
import { import {
runTiming, runTiming,
ratchetAlongWithKeyboardHeight, ratchetAlongWithKeyboardHeight,
} from '../utils/animation-utils.js'; } from '../utils/animation-utils.js';
import { useInitialNotificationsEncryptedMessage } from '../utils/crypto-utils.js';
import { import {
type StateContainer, type StateContainer,
type StateChange, type StateChange,
setStateForContainer, setStateForContainer,
} from '../utils/state-container.js'; } from '../utils/state-container.js';
import EthereumLogo from '../vectors/ethereum-logo.react.js'; import EthereumLogo from '../vectors/ethereum-logo.react.js';
let initialAppLoad = true; let initialAppLoad = true;
▲ Show 20 Lines • Show All 58 Lines • ▼ Show 20 Linestype Props = {
+cookie: ?string, +cookie: ?string,
+urlPrefix: string, +urlPrefix: string,
+loggedIn: boolean, +loggedIn: boolean,
+dimensions: DerivedDimensionsInfo, +dimensions: DerivedDimensionsInfo,
+splashStyle: ImageStyle, +splashStyle: ImageStyle,
+styles: typeof unboundStyles, +styles: typeof unboundStyles,
// Redux dispatch functions // Redux dispatch functions
+dispatch: Dispatch, +dispatch: Dispatch,
// Keyserver olm sessions functions
+initialNotificationsEncryptedMessage: () => Promise<string>,
}; };
type State = { type State = {
+mode: LoggedOutMode, +mode: LoggedOutMode,
+nextMode: LoggedOutMode, +nextMode: LoggedOutMode,
+logInState: StateContainer<LogInState>, +logInState: StateContainer<LogInState>,
+registerState: StateContainer<RegisterState>, +registerState: StateContainer<RegisterState>,
}; };
class LoggedOutModal extends React.PureComponent<Props, State> { class LoggedOutModal extends React.PureComponent<Props, State> {
▲ Show 20 Lines • Show All 163 Lines • ▼ Show 20 Lines if (!__DEV__) {
const actionSource = loggedIn const actionSource = loggedIn
? logInActionSources.appStartReduxLoggedInButInvalidCookie ? logInActionSources.appStartReduxLoggedInButInvalidCookie
: logInActionSources.appStartCookieLoggedInButInvalidRedux; : logInActionSources.appStartCookieLoggedInButInvalidRedux;
const sessionChange = await fetchNewCookieFromNativeCredentials( const sessionChange = await fetchNewCookieFromNativeCredentials(
dispatch, dispatch,
cookie, cookie,
urlPrefix, urlPrefix,
actionSource, actionSource,
this.props.initialNotificationsEncryptedMessage,
); );
if ( if (
sessionChange && sessionChange &&
sessionChange.cookie && sessionChange.cookie &&
sessionChange.cookie.startsWith('user=') sessionChange.cookie.startsWith('user=')
) { ) {
// success! we can expect subsequent actions to fix up the state // success! we can expect subsequent actions to fix up the state
return; return;
▲ Show 20 Lines • Show All 447 Lines • ▼ Show 20 Lines React.memo<BaseProps>(function ConnectedLoggedOutModal(props: BaseProps) {
const cookie = useSelector(state => state.cookie); const cookie = useSelector(state => state.cookie);
const urlPrefix = useSelector(state => state.urlPrefix); const urlPrefix = useSelector(state => state.urlPrefix);
const loggedIn = useSelector(isLoggedIn); const loggedIn = useSelector(isLoggedIn);
const dimensions = useSelector(derivedDimensionsInfoSelector); const dimensions = useSelector(derivedDimensionsInfoSelector);
const splashStyle = useSelector(splashStyleSelector); const splashStyle = useSelector(splashStyleSelector);
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatch = useDispatch(); const dispatch = useDispatch();
const callInitialNotificationsEncryptedMessage =
useInitialNotificationsEncryptedMessage();
return ( return (
<LoggedOutModal <LoggedOutModal
{...props} {...props}
isForeground={isForeground} isForeground={isForeground}
persistedStateLoaded={persistedStateLoaded} persistedStateLoaded={persistedStateLoaded}
rehydrateConcluded={rehydrateConcluded} rehydrateConcluded={rehydrateConcluded}
cookie={cookie} cookie={cookie}
urlPrefix={urlPrefix} urlPrefix={urlPrefix}
loggedIn={loggedIn} loggedIn={loggedIn}
dimensions={dimensions} dimensions={dimensions}
splashStyle={splashStyle} splashStyle={splashStyle}
styles={styles} styles={styles}
dispatch={dispatch} dispatch={dispatch}
initialNotificationsEncryptedMessage={
callInitialNotificationsEncryptedMessage
}
/> />
); );
}); });
export default ConnectedLoggedOutModal; export default ConnectedLoggedOutModal;
View Options

services/tunnelbroker/Dockerfile

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Linesimport type {
EventSubscription, EventSubscription,
KeyboardEvent, KeyboardEvent,
} from '../types/react-native.js'; } from '../types/react-native.js';
import type { ImageStyle } from '../types/styles.js'; import type { ImageStyle } from '../types/styles.js';
import { import {
runTiming, runTiming,
ratchetAlongWithKeyboardHeight, ratchetAlongWithKeyboardHeight,
} from '../utils/animation-utils.js'; } from '../utils/animation-utils.js';
import { useInitialNotificationsEncryptedMessage } from '../utils/crypto-utils.js';
import { import {
type StateContainer, type StateContainer,
type StateChange, type StateChange,
setStateForContainer, setStateForContainer,
} from '../utils/state-container.js'; } from '../utils/state-container.js';
import EthereumLogo from '../vectors/ethereum-logo.react.js'; import EthereumLogo from '../vectors/ethereum-logo.react.js';
let initialAppLoad = true; let initialAppLoad = true;
▲ Show 20 Lines • Show All 58 Lines • ▼ Show 20 Linestype Props = {
+cookie: ?string, +cookie: ?string,
+urlPrefix: string, +urlPrefix: string,
+loggedIn: boolean, +loggedIn: boolean,
+dimensions: DerivedDimensionsInfo, +dimensions: DerivedDimensionsInfo,
+splashStyle: ImageStyle, +splashStyle: ImageStyle,
+styles: typeof unboundStyles, +styles: typeof unboundStyles,
// Redux dispatch functions // Redux dispatch functions
+dispatch: Dispatch, +dispatch: Dispatch,
// Keyserver olm sessions functions
+initialNotificationsEncryptedMessage: () => Promise<string>,
}; };
type State = { type State = {
+mode: LoggedOutMode, +mode: LoggedOutMode,
+nextMode: LoggedOutMode, +nextMode: LoggedOutMode,
+logInState: StateContainer<LogInState>, +logInState: StateContainer<LogInState>,
+registerState: StateContainer<RegisterState>, +registerState: StateContainer<RegisterState>,
}; };
class LoggedOutModal extends React.PureComponent<Props, State> { class LoggedOutModal extends React.PureComponent<Props, State> {
▲ Show 20 Lines • Show All 163 Lines • ▼ Show 20 Lines if (!__DEV__) {
const actionSource = loggedIn const actionSource = loggedIn
? logInActionSources.appStartReduxLoggedInButInvalidCookie ? logInActionSources.appStartReduxLoggedInButInvalidCookie
: logInActionSources.appStartCookieLoggedInButInvalidRedux; : logInActionSources.appStartCookieLoggedInButInvalidRedux;
const sessionChange = await fetchNewCookieFromNativeCredentials( const sessionChange = await fetchNewCookieFromNativeCredentials(
dispatch, dispatch,
cookie, cookie,
urlPrefix, urlPrefix,
actionSource, actionSource,
this.props.initialNotificationsEncryptedMessage,
); );
if ( if (
sessionChange && sessionChange &&
sessionChange.cookie && sessionChange.cookie &&
sessionChange.cookie.startsWith('user=') sessionChange.cookie.startsWith('user=')
) { ) {
// success! we can expect subsequent actions to fix up the state // success! we can expect subsequent actions to fix up the state
return; return;
▲ Show 20 Lines • Show All 447 Lines • ▼ Show 20 Lines React.memo<BaseProps>(function ConnectedLoggedOutModal(props: BaseProps) {
const cookie = useSelector(state => state.cookie); const cookie = useSelector(state => state.cookie);
const urlPrefix = useSelector(state => state.urlPrefix); const urlPrefix = useSelector(state => state.urlPrefix);
const loggedIn = useSelector(isLoggedIn); const loggedIn = useSelector(isLoggedIn);
const dimensions = useSelector(derivedDimensionsInfoSelector); const dimensions = useSelector(derivedDimensionsInfoSelector);
const splashStyle = useSelector(splashStyleSelector); const splashStyle = useSelector(splashStyleSelector);
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatch = useDispatch(); const dispatch = useDispatch();
const callInitialNotificationsEncryptedMessage =
useInitialNotificationsEncryptedMessage();
return ( return (
<LoggedOutModal <LoggedOutModal
{...props} {...props}
isForeground={isForeground} isForeground={isForeground}
persistedStateLoaded={persistedStateLoaded} persistedStateLoaded={persistedStateLoaded}
rehydrateConcluded={rehydrateConcluded} rehydrateConcluded={rehydrateConcluded}
cookie={cookie} cookie={cookie}
urlPrefix={urlPrefix} urlPrefix={urlPrefix}
loggedIn={loggedIn} loggedIn={loggedIn}
dimensions={dimensions} dimensions={dimensions}
splashStyle={splashStyle} splashStyle={splashStyle}
styles={styles} styles={styles}
dispatch={dispatch} dispatch={dispatch}
initialNotificationsEncryptedMessage={
callInitialNotificationsEncryptedMessage
}
/> />
); );
}); });
export default ConnectedLoggedOutModal; export default ConnectedLoggedOutModal;