Differential D5105

[Chore] Add new protos build dir to gitignore
ClosedPublic
Actions

Authored by • jon on Sep 9 2022, 4:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 26, 4:59 AM

	Unknown Object (File)
	Tue, Mar 18, 9:57 AM

	Unknown Object (File)
	Mon, Mar 17, 4:08 AM

	Unknown Object (File)
	Mon, Mar 17, 4:08 AM

	Unknown Object (File)
	Mon, Mar 17, 4:08 AM

	Unknown Object (File)
	Sat, Mar 15, 10:09 PM

	Unknown Object (File)
	Wed, Mar 12, 2:33 AM

	Unknown Object (File)
	Tue, Mar 11, 8:07 PM

Subscribers

Details

Reviewers

atul
varun
• abosh

Commits

rCOMM0721bc662099: [Chore] Add new protos build dir to gitignore

Summary

Follow up to D4992. Ignore build directory

Test Plan

N/A

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Sep 9 2022, 4:46 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 9 2022, 4:46 PM

Harbormaster completed remote builds in B12064: Diff 16564.Sep 9 2022, 4:56 PM

• jon requested review of this revision.Sep 9 2022, 4:56 PM

• jon added a child revision: D5106: [CMake] Use correct protobuf capitalization.Sep 12 2022, 9:56 AM

atul accepted this revision.Sep 12 2022, 10:14 AM

This revision is now accepted and ready to land.Sep 12 2022, 10:14 AM

Closed by commit rCOMM0721bc662099: [Chore] Add new protos build dir to gitignore (authored by • jon). · Explain WhySep 12 2022, 10:50 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM0721bc662099: [Chore] Add new protos build dir to gitignore.

Revision Contents
Changeset List

Path

Size

1 line

Diff 16592

.gitignore

This file was added.

				// 400KiB limit (in docs there is KB but they mean KiB) -
				// https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/ServiceQuotas.html
				// This includes both attribute names' and values' lengths
				pub const DDB_ITEM_SIZE_LIMIT: usize = 1024 * 400;

				// 4MB limit
				// WARNING: use keeping in mind that grpc adds its own headers to messages
				// https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md
				// so the message that actually is being sent over the network looks like this
				// [Compressed-Flag] [Message-Length] [Message]
				// [Compressed-Flag] 1 byte - added by grpc
				// [Message-Length] 4 bytes - added by grpc
				// [Message] N bytes - actual data
				// so for every message we get 5 additional bytes of data
				// as mentioned here
				// https://github.com/grpc/grpc/issues/15734#issuecomment-396962671
				// grpc stream may contain more than one message
				pub const GRPC_CHUNK_SIZE_LIMIT: usize = 4 * 1024 * 1024;
				pub const GRPC_METADATA_SIZE_PER_MESSAGE: usize = 5;