Page MenuHomePhabricator
Differential D5193

[keyserver] Introduce `constructMediaFromMediaMessageContentsAndUploadRows`
ClosedPublic
Actions

Authored by atul on Sep 20 2022, 7:24 AM.
Tags
None
Referenced Files
F3366374: D5193.id16961.diff
Mon, Nov 25, 11:09 AM
Unknown Object (File)
Fri, Nov 22, 12:07 PM
Unknown Object (File)
Fri, Nov 22, 12:01 PM
Unknown Object (File)
Fri, Nov 22, 11:41 AM
Unknown Object (File)
Wed, Nov 20, 1:40 AM
Unknown Object (File)
Mon, Nov 11, 2:51 AM
Unknown Object (File)
Fri, Nov 8, 6:58 AM
Unknown Object (File)
Fri, Nov 8, 1:59 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
• abosh
varun
Commits
rCOMM12ac24c6b7b1: [keyserver] Introduce `constructMediaFromMediaMessageContentsAndUploadRows`
Summary

Pull functionality out of fetchMediaFromMediaMessageContent(...) so it can be reused in rawMessageInfoFromRows(...) to reconstruct Media objects for MULTIMEDIA messages.

The difference between the two is that in fetchMediaFromMediaMessageContent(...) is we're fetching the upload rows whereas in rawMessageInfoFromRows(...) they're given to us.

In next diff we'll consume this function in rawMessageInfoFromRows to correctly pull MULTIMEDIA messages from the DB given the the content column of the message (stringified MediaMessageServerDBContent in addition to the upload rows.

Depends on D5191

Test Plan

Refactor, things continue to work as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Sep 20 2022, 7:24 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2022, 7:24 AM
atul updated this revision to Diff 16911.Sep 20 2022, 7:24 AM

cut extraneous newline (if i had a nickel)

atul updated this revision to Diff 16912.Sep 20 2022, 7:25 AM

fix

atul updated this revision to Diff 16913.Sep 20 2022, 7:26 AM

fix

atul edited the summary of this revision. (Show Details)Sep 20 2022, 7:26 AM
Harbormaster completed remote builds in B12319: Diff 16910.Sep 20 2022, 7:33 AM
Harbormaster completed remote builds in B12320: Diff 16911.
Harbormaster completed remote builds in B12321: Diff 16912.Sep 20 2022, 7:37 AM
Harbormaster completed remote builds in B12322: Diff 16913.
atul requested review of this revision.Sep 20 2022, 7:38 AM
atul added a child revision: D5195: [keyserver] Construct `MULTIMEDIA` message media correctly in `rawMessageInfoFromRows(...)`.Sep 20 2022, 8:46 AM
tomek accepted this revision.Sep 21 2022, 6:29 AM
This revision is now accepted and ready to land.Sep 21 2022, 6:29 AM
atul updated this revision to Diff 16960.Sep 21 2022, 1:37 PM

rebase before landing

This revision was landed with ongoing or failed builds.Sep 21 2022, 1:39 PM
Closed by commit rCOMM12ac24c6b7b1: [keyserver] Introduce `constructMediaFromMediaMessageContentsAndUploadRows` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM12ac24c6b7b1: [keyserver] Introduce `constructMediaFromMediaMessageContentsAndUploadRows`.
Harbormaster completed remote builds in B12354: Diff 16960.Sep 21 2022, 1:48 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
16 lines

Diff 16910

View Options

keyserver/src/fetchers/upload-fetchers.js

Loading...