Page MenuHomePhabricator

[lib] Persist messages after user account is deleted
ClosedPublic

Authored by rohan on Sep 20 2022, 2:03 PM.
Tags
None
Referenced Files
F4111670: D5199.id16932.diff
Mon, Feb 17, 8:55 PM
F4111669: D5199.id16934.diff
Mon, Feb 17, 8:55 PM
F4111653: D5199.id.diff
Mon, Feb 17, 8:55 PM
F4111594: D5199.diff
Mon, Feb 17, 8:50 PM
Unknown Object (File)
Sat, Feb 8, 8:43 PM
Unknown Object (File)
Jan 12 2025, 10:39 PM
Unknown Object (File)
Jan 3 2025, 4:54 PM
Unknown Object (File)
Jan 3 2025, 4:54 PM

Details

Summary

After a user deletes their account, there is a bug that deletes
their messages from another user's device and removes any trace of
conversation. This diff addresses that by instead persisting the messages,
but replacing the deleted user's account name with anonymous to signify a
deleted account.

Addresses: https://linear.app/comm/issue/ENG-1735/messages-of-a-deleted-account-dont-show-up-in-the-app

Test Plan

Simulated a conversation between two individuals and observed
that, as expected, the deleted user is renamed to anonymous and their
messages persist. In a group chat, the same behavior is expected, where
the user is removed from the group but their messages persist and it is
authored by anonymous.

Video Demo:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan requested review of this revision.Sep 20 2022, 2:13 PM
rohan edited the test plan for this revision. (Show Details)
rohan attached a referenced file: F176142: ENG-1735 Demo.mov. (Show Details)
ashoat removed 1 blocking reviewer(s): atul.

Short-circuiting review since this was what we discussed in the Linear issue

This revision is now accepted and ready to land.Sep 20 2022, 2:34 PM