Page MenuHomePhabricator
Differential D5203

[services] Move constants to a separate file in commtest
ClosedPublic
Actions

Authored by michal on Sep 21 2022, 4:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 6:29 AM
Unknown Object (File)
Tue, Nov 5, 6:29 AM
Unknown Object (File)
Tue, Nov 5, 6:29 AM
Unknown Object (File)
Tue, Nov 5, 6:28 AM
Unknown Object (File)
Tue, Nov 5, 6:26 AM
Unknown Object (File)
Tue, Oct 22, 11:33 PM
Unknown Object (File)
Tue, Oct 22, 9:37 PM
Unknown Object (File)
Mon, Oct 21, 11:01 PM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
varun
• jon
marcin
tomek
Commits
rCOMMa8a7d9c7e94f: [services] Move constants to a separate file in commtest
Summary

ENG-1322
Moves constants from tools.rs to constants.rs.

Test Plan

Check if it builds

cd services/commtest
cargo test --no-run

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.Sep 21 2022, 4:49 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 21 2022, 4:49 AM
Harbormaster completed remote builds in B12343: Diff 16945.Sep 21 2022, 4:59 AM
michal requested review of this revision.Sep 21 2022, 4:59 AM
• jon accepted this revision.Sep 21 2022, 10:45 AM

LGTM, I like it

This revision is now accepted and ready to land.Sep 21 2022, 10:45 AM
michal added 1 blocking reviewer(s): marcin.Sep 27 2022, 5:09 AM
This revision now requires review to proceed.Sep 27 2022, 5:09 AM
marcin accepted this revision.Sep 27 2022, 6:53 AM
This revision is now accepted and ready to land.Sep 27 2022, 6:53 AM
michal added a reviewer: tomek.Sep 27 2022, 7:06 AM
This revision now requires review to proceed.Sep 27 2022, 7:06 AM
tomek accepted this revision.Sep 27 2022, 7:53 AM

Actually, it might be a good idea to run these instead of just compiling.

This revision is now accepted and ready to land.Sep 27 2022, 7:53 AM
michal updated this revision to Diff 17181.Sep 29 2022, 5:08 AM

Rebase on master, run the tests instead of just compiling

Harbormaster completed remote builds in B12520: Diff 17181.Sep 29 2022, 5:18 AM
Closed by commit rCOMMa8a7d9c7e94f: [services] Move constants to a separate file in commtest (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhySep 29 2022, 5:23 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMa8a7d9c7e94f: [services] Move constants to a separate file in commtest.

Revision Contents
Changeset List

PathSize
services/
commtest/
src/
backup/
3 lines
3 lines
13 lines
1 line
13 lines
tests/
10 lines
11 lines

Diff 17183

View Options

services/commtest/src/backup/add_attachments.rs

Loading...
View Options

services/commtest/src/backup/pull_backup.rs

Loading...
View Options

services/commtest/src/constants.rs

Loading...
View Options

services/commtest/src/lib.rs

Loading...
View Options

services/commtest/src/tools.rs

Loading...
View Options

services/commtest/tests/backup_integration_test.rs

Loading...
View Options

services/commtest/tests/blob_integration_test.rs

Loading...