Page MenuHomePhabricator
Differential D5213

[native] Type global.CommCoreModule
ClosedPublic
Actions

Authored by michal on Sep 22 2022, 6:27 AM.
Tags
None
Referenced Files
F3112022: D5213.diff
Thu, Oct 31, 4:05 PM
Unknown Object (File)
Thu, Oct 24, 5:55 AM
Unknown Object (File)
Thu, Oct 24, 4:59 AM
Unknown Object (File)
Thu, Oct 24, 4:56 AM
Unknown Object (File)
Thu, Oct 24, 2:43 AM
Unknown Object (File)
Sat, Oct 5, 10:39 PM
Unknown Object (File)
Sep 22 2024, 10:55 PM
Unknown Object (File)
Sep 14 2024, 5:06 AM
View All 45 Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
• abosh
• jakub
inka
ashoat
Commits
rCOMM88359e06a697: [native] Type global.CommCoreModule
Summary

(ENG-1856)[https://linear.app/comm/issue/ENG-1856/globalcommcoremodule-should-be-typed]
Re-export global.CommCoreModule typed as Spec from ./schema/CommCoreModuleSchema and update all usages.

Test Plan
  1. Run flow to check if everything type checks
  2. Run the app and check if there's anything wrong

Diff Detail

Repository
rCOMM Comm
Branch
eng1856
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 16990

View Options

native/data/core-data-provider.react.js

Loading...
View Options

native/data/core-data.js

Loading...
View Options

native/data/sensitive-data-cleaner.react.js

Loading...
View Options

native/data/sqlite-context-provider.js

Loading...
View Options

native/native-modules.js

Loading...
View Options

native/redux/persist.js

Loading...
View Options

native/redux/redux-setup.js

Loading...
View Options

native/selectors/socket-selectors.js

Loading...