[lib/ native] Rename fetchJSON to callServerEndpoint
ClosedPublic
Actions

Authored by michal on Sep 28 2022, 2:10 AM.

Details

Reviewers

tomek
atul
• abosh

Commits

rCOMM657c5af21331: [lib/ native] Rename fetchJSON to callServerEndpoint

Summary

Renames fetchJSON to callServerEndpoint and changes accompanying types to match.

Test Plan

Run flow
Test some basic things in the native and web app to check if it works

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Sep 28 2022, 2:10 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 28 2022, 2:10 AM

Harbormaster completed remote builds in B12481: Diff 17128.Sep 28 2022, 2:21 AM

michal requested review of this revision.Sep 28 2022, 2:21 AM

tomek accepted this revision.Sep 28 2022, 10:07 AM

tomek added inline comments.

lib/utils/action-utils.js
148 ↗	(On Diff #17128)	This doesn't read too well. Maybe `serverEndpointCallsWaitingForNewCookie`
375–376 ↗	(On Diff #17128)	This comment is slightly outdated - I'm pretty sure we don't use `mapStateToProps` anymore. I think that we can just skip the irrelevant part, but would like to get @ashoat perspective

This revision is now accepted and ready to land.Sep 28 2022, 10:07 AM

tomek added inline comments.Sep 29 2022, 2:03 AM

lib/utils/action-utils.js
375–376 ↗	(On Diff #17128)	The fact that this comment is outdated doesn't really affect this diff, so I think a better approach would be to create a task and discuss there. @michal could you create it?

michal added inline comments.Sep 29 2022, 2:38 AM

lib/utils/action-utils.js
375–376 ↗	(On Diff #17128)	Sure, here ENG-1916

Additional rename, rebase

Harbormaster completed remote builds in B12511: Diff 17171.Sep 29 2022, 3:11 AM

Closed by commit rCOMM657c5af21331: [lib/ native] Rename fetchJSON to callServerEndpoint (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhySep 29 2022, 3:16 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM657c5af21331: [lib/ native] Rename fetchJSON to callServerEndpoint.

In retrospect we probably should've called this callKeyserverEndpoint, but we can save that rename for when we introduce multi-keyserver support (we'll need to change the function signature then)

inka mentioned this in D5109: [native] Add client side logic of message reporting.Sep 30 2022, 4:20 AM