[native] added arrows for threads in chat inbox
ClosedPublic
Actions

Authored by ginsu on Sep 29 2022, 2:06 PM.

Details

Reviewers

atul
• abosh
rohan

Commits

rCOMM2bc3e2c46ace: [native] added arrows for threads in chat inbox

Summary

Implemented the arrows design for threads in chat inbox. Removed the icon, and moved the unread dot logic from chat-thread-list-item.react to chat-thread-list-sidebar

Next steps/diffs:

Include arrow design to be a part of SidebarListModal as well

won't land this diff until the next diff is also approved and ready to land

Linear Task: ENG-1779

Depends on D5253 and D5264

Test Plan

Please view the video and the Figma designs attached to review the visual changes I made

Before:

Screen Shot 2022-09-29 at 5.18.51 PM.png (1×1 px, 675 KB)

After:

Figma:
Normal State
Swipe State

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 29 2022, 2:06 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 29 2022, 2:06 PM

ginsu added inline comments.Sep 29 2022, 2:11 PM

native/chat/chat-thread-list-sidebar.react.js
30–42 ↗	(On Diff #17210)	Used the web Sidebar Item component as inspiration

Harbormaster completed remote builds in B12542: Diff 17210.Sep 29 2022, 2:17 PM

ginsu requested review of this revision.Sep 29 2022, 2:17 PM

ginsu edited the summary of this revision. (Show Details)Sep 29 2022, 2:20 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added parent revisions: D5264: [native] created arrow-long component, D5253: [native] created arrow component.

ginsu attached a referenced file: F186388: Screen Recording 2022-09-29 at 4.41.53 PM.mov. (Show Details)

ginsu attached a referenced file: F186391: Screen Shot 2022-09-29 at 5.18.51 PM.png. (Show Details)

ginsu added reviewers: atul, • abosh, rohan.

The demo in the diff description looks great! However, I don't think we can move the UnreadDot from SidebarItem to ChatThreadListSidebar so easily..

Based on a quick search of the codebase we use SidebarItem in other components (eg SidebarListModal)... are we sure that this change won't break things there? At a high level it's always good to look through the codebase for other usages of a component to see if there may be any unintended visual side effects.

~~But definitely let me know if I'm missing something/you already considered other usages of the component/etc~~

Discussed IRL, all other cases were considered by @ginsu

This revision now requires changes to proceed.Sep 30 2022, 11:59 AM