Page MenuHomePhabricator
Differential D5283

[native] implemented arrows UI to sidebar list modal component
ClosedPublic
Actions

Authored by ginsu on Oct 3 2022, 6:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 5:09 PM
Unknown Object (File)
Wed, Jan 1, 5:09 PM
Unknown Object (File)
Wed, Jan 1, 5:09 PM
Unknown Object (File)
Wed, Jan 1, 5:02 PM
Unknown Object (File)
Dec 1 2024, 10:17 PM
Unknown Object (File)
Dec 1 2024, 10:17 PM
Unknown Object (File)
Dec 1 2024, 8:09 PM
Unknown Object (File)
Nov 25 2024, 10:29 PM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
atul
• abosh
rohan
ashoat
Commits
rCOMMfae32ea5a5c5: [native] implemented arrows UI to sidebar list modal component
Summary

Implemented arrows UI to sidebar list modal component. There was no official design on Figma, so I based the design on the web app

Web app design:

Screen Shot 2022-10-03 at 9.30.14 AM.png (1×1 px, 140 KB)

Linear Task: ENG-1779

Depends on D5268

Test Plan

Please view the screenshots to see the before and after of the changes I made:

Before:

Screen Shot 2022-10-03 at 9.35.27 AM.png (1×1 px, 574 KB)

After:

Screen Shot 2022-10-03 at 9.22.11 AM.png (1×1 px, 573 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 3 2022, 6:28 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 3 2022, 6:28 AM
ginsu edited the summary of this revision. (Show Details)Oct 3 2022, 6:35 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, • abosh, rohan.
ginsu added a parent revision: D5268: [native] added arrows for threads in chat inbox.
ginsu attached a referenced file: F189273: Screen Shot 2022-10-03 at 9.22.11 AM.png. (Show Details)
ginsu attached a referenced file: F189275: Screen Shot 2022-10-03 at 9.35.27 AM.png. (Show Details)
ginsu attached a referenced file: F189272: Screen Shot 2022-10-03 at 9.30.14 AM.png. (Show Details)
Harbormaster completed remote builds in B12582: Diff 17286.Oct 3 2022, 6:36 AM
ginsu requested review of this revision.Oct 3 2022, 6:36 AM
atul accepted this revision.Oct 3 2022, 1:46 PM
atul added a reviewer: ashoat.

In the thread list the arrows are "coming out" of the profile picture/color splotch, whereas here they're kind of coming out of the search bar? It's not super clear..

My instinct is that this is fine for now, but it's the type of thing a designer should look at eventually

Accepting and adding @ashoat as blocking since there's some subjectiveness around design here.

atul added a comment.Oct 3 2022, 1:47 PM

As an aside, there's not much contrast between the modal and the underlying views. Can we create a Linear task for adding a drop shadow or "glow" to the modal (and probably all modals) to help provide the user with some sense of depth?

ashoat accepted this revision.Oct 3 2022, 2:03 PM
This revision is now accepted and ready to land.Oct 3 2022, 2:03 PM
Closed by commit rCOMMfae32ea5a5c5: [native] implemented arrows UI to sidebar list modal component (authored by ginsu). · Explain WhyOct 3 2022, 2:20 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMfae32ea5a5c5: [native] implemented arrows UI to sidebar list modal component.
ashoat added a comment.Oct 3 2022, 2:40 PM

Can we create a Linear task for adding a drop shadow or "glow" to the modal (and probably all modals) to help provide the user with some sense of depth?

https://linear.app/comm/issue/ENG-1955/add-dropshadowglow-effect-to-modal-component

(Always good to link these before landing)

ginsu added a comment.Oct 3 2022, 2:41 PM

okay good to know, I'll make sure to do that next time

Revision Contents
Changeset List

PathSize
native/
chat/
35 lines

Diff 17309

View Options

native/chat/sidebar-list-modal.react.js

Loading...