Page MenuHomePhabricator
Differential D5290

[native/sqlite] add `IF NOT EXISTS` constraint to migrations
ClosedPublic
Actions

Authored by kamil on Oct 4 2022, 2:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 1:07 AM
Unknown Object (File)
Sun, Nov 3, 12:36 AM
Unknown Object (File)
Sun, Nov 3, 12:36 AM
Unknown Object (File)
Sun, Nov 3, 12:36 AM
Unknown Object (File)
Sun, Nov 3, 12:35 AM
Unknown Object (File)
Sun, Nov 3, 12:29 AM
Unknown Object (File)
Sep 26 2024, 10:16 PM
Unknown Object (File)
Sep 26 2024, 10:16 PM
View All Files
Subscribers
• abosh
ashoat
atul
• max

Details

Reviewers
tomek
• jon
atul
marcin
Commits
rCOMMf50455b6eeb4: [native/sqlite] add `IF NOT EXISTS` constraint to migrations
Summary

More context in this linear task with bug description.

This diff allows running all migration multiple times without crashing.

Test Plan
  1. This reproduce plan
  2. Comment this line and reload app twice (without logout to check if this works on the same database instance)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Oct 4 2022, 2:07 AM
kamil held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptOct 4 2022, 2:07 AM
Herald added subscribers: • abosh, atul, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B12592: Diff 17314.Oct 4 2022, 2:16 AM
kamil edited the summary of this revision. (Show Details)Oct 4 2022, 2:37 AM
kamil edited the test plan for this revision. (Show Details)
kamil added reviewers: atul, marcin.
kamil added a subscriber: • max.
kamil published this revision for review.Oct 4 2022, 3:00 AM
kamil edited the summary of this revision. (Show Details)
tomek accepted this revision.Oct 4 2022, 4:31 AM
tomek added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
144 ↗(On Diff #17314)

Can we add IF NOT EXISTS also here?

This revision is now accepted and ready to land.Oct 4 2022, 4:31 AM
kamil added inline comments.Oct 4 2022, 4:37 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
144 ↗(On Diff #17314)

In theory, it's not needed.

First, table is dropped, then re-create and after this indexed is created so it won't fail, but I agree can be added just for clarity, will do!

ashoat mentioned this in D5292: [native/sqlite] set `journal_mode` on fresh install.Oct 4 2022, 7:13 AM
kamil updated this revision to Diff 17323.Oct 4 2022, 8:44 AM

add IF NOT EXISTS for messages_idx_thread_time

Harbormaster completed remote builds in B12600: Diff 17323.Oct 4 2022, 8:52 AM
marcin accepted this revision.Oct 5 2022, 3:42 AM
Closed by commit rCOMMf50455b6eeb4: [native/sqlite] add `IF NOT EXISTS` constraint to migrations (authored by kamil, committed by ashoat). · Explain WhyOct 7 2022, 6:46 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf50455b6eeb4: [native/sqlite] add `IF NOT EXISTS` constraint to migrations.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
8 lines

Diff 17415

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...