[landing] added new team members
ClosedPublic
Actions

Authored by ginsu on Oct 4 2022, 1:49 PM.

Details

Reviewers

atul
rohan
• abosh
ashoat

Commits

rCOMM95f37063fdd4: [landing] added new team members

Summary

added new team members, had to make one small style change to fix case when team member does not have twitter or github (see image below for reference)

Screen Shot 2022-10-04 at 4.14.11 PM.png (2×3 px, 2 MB)

Next diff:

Will make small style changes to make the layout a bit cleaner

Linear Task: ENG-1506

Test Plan

Please see the screenshot to see the before and after:

Before:

Screen Shot 2022-10-04 at 4.48.58 PM.png (2×3 px, 2 MB)

Screen Shot 2022-10-04 at 4.49.01 PM.png (2×3 px, 2 MB)

After:

Screen Shot 2022-10-04 at 4.58.19 PM.png (1×3 px, 3 MB)

Screen Shot 2022-10-04 at 4.47.15 PM.png (2×3 px, 2 MB)

Diff Detail

Repository

rCOMM Comm

Branch

eng-1506

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 4 2022, 1:49 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 4 2022, 1:49 PM

atul published this revision for review.Oct 4 2022, 1:53 PM

atul added inline comments.

landing/team.react.js
78	Sorry, I know I said "Researcher" but I think his "official"-ish title is "Research Scientist" so let's change it to that

atul accepted this revision.Oct 4 2022, 1:53 PM

This revision is now accepted and ready to land.Oct 4 2022, 1:53 PM

ginsu edited the summary of this revision. (Show Details)Oct 4 2022, 1:54 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: rohan, • abosh, ashoat.

ginsu attached a referenced file: F190590: Screen Shot 2022-10-04 at 4.47.15 PM.png. (Show Details)

ginsu attached a referenced file: F190588: Screen Shot 2022-10-04 at 4.47.12 PM.png. (Show Details)

ginsu attached a referenced file: F190587: Screen Shot 2022-10-04 at 4.49.01 PM.png. (Show Details)

ginsu attached a referenced file: F190586: Screen Shot 2022-10-04 at 4.48.58 PM.png. (Show Details)

ginsu attached a referenced file: F190584: Screen Shot 2022-10-04 at 4.14.11 PM.png. (Show Details)

changed anunays title

ginsu edited the test plan for this revision. (Show Details)Oct 4 2022, 1:58 PM

ginsu attached a referenced file: F190616: Screen Shot 2022-10-04 at 4.58.19 PM.png. (Show Details)

Harbormaster completed remote builds in B12604: Diff 17328.Oct 4 2022, 2:01 PM

Looks good, adding @ashoat as blocking since this is "public facing"

(Discussed layout w/ @ginsu which will be updated in next diff)

This revision now requires review to proceed.Oct 4 2022, 2:03 PM

Harbormaster completed remote builds in B12605: Diff 17329.Oct 4 2022, 2:07 PM

ginsu mentioned this in D5296: [landing] updated layout of team members wrapper.Oct 4 2022, 2:16 PM

Looks great to me! Curious if it might be better to make it into a something like a carousel to click through down the line (especially to not have a lone photo on it's on row), though I doubt that's a consideration for this diff.

Looks great!!

This revision is now accepted and ready to land.Oct 4 2022, 6:27 PM

Closed by commit rCOMM95f37063fdd4: [landing] added new team members (authored by ginsu). · Explain WhyOct 6 2022, 7:06 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM95f37063fdd4: [landing] added new team members.

ginsu mentioned this in rCOMMbf0b0753e1d8: [landing] updated layout of team members wrapper.