Paths

Table of Contentst

Differential D5299

[services] Backup - use `anyhow::Result` short form
ClosedPublic
Actions

Authored by bartek on Oct 5 2022, 3:59 AM.

Tags

None

Referenced Files

	F3247549: D5299.diff
	Fri, Nov 15, 5:56 AM

	Unknown Object (File)
	Sat, Nov 9, 8:09 PM

	Unknown Object (File)
	Sat, Nov 9, 8:09 PM

	Unknown Object (File)
	Sat, Nov 9, 8:08 PM

	Unknown Object (File)
	Tue, Nov 5, 2:07 AM

	Unknown Object (File)
	Oct 5 2024, 11:42 AM

	Unknown Object (File)
	Oct 5 2024, 11:42 AM

	Unknown Object (File)
	Oct 5 2024, 11:42 AM

Subscribers

Details

Reviewers

• jon
marcin
tomek

Commits

rCOMMc040c3fbe885: [services] Backup - use `anyhow::Result` short form

Summary

According to the Rust docs:

Use Result<T, anyhow::Error>, or equivalently anyhow::Result<T>, as the return type of any fallible function.

I replaced all occurrences of anyhow::Result<T, anyhow::Error> with anyhow::Result<T>.

Related Linear issue: ENG-1841

Test Plan

Backup service container builds.
Integration tests pass.

Diff Detail

Repository

Branch

@barthap/anyhow-result

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Oct 5 2022, 3:59 AM

Herald added a reviewer: • jon. · View Herald TranscriptOct 5 2022, 3:59 AM

Herald added subscribers: • abosh, atul, ashoat. · View Herald Transcript

bartek edited the summary of this revision. (Show Details)Oct 5 2022, 4:01 AM

bartek edited the summary of this revision. (Show Details)Oct 5 2022, 4:06 AM

Harbormaster completed remote builds in B12623: Diff 17347.Oct 5 2022, 4:10 AM

bartek requested review of this revision.Oct 5 2022, 4:10 AM

tomek edited reviewers, added: marcin; removed: tomek.Oct 5 2022, 4:27 AM

Documentation states that we can replace Result<T, anyhow::Error> (std::result::Result<T, anyhow::Error>) with anyhow::Result<T>. We are replacing anyhow::Result<T, anyhow::Error> with anyhow::Result<T>. Probably I am missing something since compilation succeeds so definitely not going to block this differential on it.

This revision is now accepted and ready to land.Oct 5 2022, 5:08 AM

marcin added a reviewer: tomek.Oct 5 2022, 5:09 AM

This revision now requires review to proceed.Oct 5 2022, 5:09 AM

• jon accepted this revision.Oct 5 2022, 9:10 AM

In D5299#156308, @marcin wrote:

Documentation states that we can replace Result<T, anyhow::Error> (std::result::Result<T, anyhow::Error>) with anyhow::Result<T>. We are replacing anyhow::Result<T, anyhow::Error> with anyhow::Result<T>. Probably I am missing something since compilation succeeds so definitely not going to block this differential on it.

Good question! According to the docs https://docs.rs/anyhow/latest/anyhow/type.Result.html Result<T> is

equivalent to std::result::Result<T, anyhow::Error>

And Result<T, OtherError> is

equivalent to std::result::Result<T, OtherError>

So anyhow::Result<T> is equivalent to std::result::Result<T, anyhow::Error> which is equivalent to anyhow::Result<T, anyhow::Error>.

This revision is now accepted and ready to land.Oct 6 2022, 1:02 AM

Closed by commit rCOMMc040c3fbe885: [services] Backup - use `anyhow::Result` short form (authored by bartek). · Explain WhyOct 6 2022, 1:10 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMc040c3fbe885: [services] Backup - use `anyhow::Result` short form.

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

10 lines

12 lines

Diff 17347

services/backup/blob_client/src/get_client.rs

Loading...

services/backup/blob_client/src/put_client.rs

Loading...