Page MenuHomePhabricator
Differential D5303

[native] Rename the lib directory to third-party
ClosedPublic
Actions

Authored by rohan on Oct 5 2022, 9:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 11, 6:08 AM
Unknown Object (File)
Tue, Sep 10, 10:35 PM
Unknown Object (File)
Tue, Sep 10, 10:35 PM
Unknown Object (File)
Tue, Sep 10, 10:35 PM
Unknown Object (File)
Tue, Sep 10, 10:35 PM
Unknown Object (File)
Tue, Sep 10, 10:35 PM
Unknown Object (File)
Tue, Sep 10, 10:35 PM
Unknown Object (File)
Tue, Sep 10, 10:35 PM
View All Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
atul
ginsu
• jon
ashoat
Commits
rCOMM42e7c48a2325: [native] Rename the lib directory to third-party
Summary

Renamed the directory using git mv and changed paths in the
codebase from lib/sqlite_orm to third-party/sqlite_orm

Test Plan

Restarted the keyserver and native with yarn dev both
before and after the changes, and both run successfully.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Oct 5 2022, 9:33 AM
Herald added a reviewer: • jon. · View Herald TranscriptOct 5 2022, 9:33 AM
Herald added subscribers: • abosh, tomek. · View Herald Transcript
rohan added a comment.EditedOct 5 2022, 9:34 AM

Also curious to see if the builds succeed here.

iOS fails with the following error:

/opt/homebrew/var/buildkite-agent/builds/mac-spring-local-1/comm/ios-build/native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp:4:10: fatal error: 'sqlite_orm.h' file not found
#include "sqlite_orm.h"
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 5 2022, 9:37 AM
Harbormaster failed remote builds in B12634: Diff 17364!
rohan updated this revision to Diff 17369.Oct 5 2022, 11:17 AM

Attempt to add native/cpp/third-party to the header search path to try
to fix iOS build failing

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 5 2022, 11:22 AM
Harbormaster failed remote builds in B12639: Diff 17369!
rohan updated this revision to Diff 17371.Oct 5 2022, 11:23 AM

Typo fix

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 5 2022, 11:28 AM
Harbormaster failed remote builds in B12641: Diff 17371!
rohan updated this revision to Diff 17372.Oct 5 2022, 11:35 AM

Revert back to first revision

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 5 2022, 11:40 AM
Harbormaster failed remote builds in B12642: Diff 17372!
rohan updated this revision to Diff 17373.Oct 5 2022, 12:10 PM

Modify sqlite_orm.h file reference in XCode

Harbormaster completed remote builds in B12643: Diff 17373.Oct 5 2022, 12:22 PM
rohan requested review of this revision.Oct 5 2022, 12:22 PM
atul accepted this revision.Oct 5 2022, 12:28 PM

Looks good to me (and CI passes)!

This revision is now accepted and ready to land.Oct 5 2022, 12:28 PM
ashoat resigned from this revision.Oct 6 2022, 5:57 AM

Best to leave me off the first pass of a review, except in these cases or if I have some special context on the code change

rohan added a subscriber: ashoat.Oct 6 2022, 6:01 AM
In D5303#156671, @ashoat wrote:

Best to leave me off the first pass of a review, except in these cases or if I have some special context on the code change

Ah thanks for the heads up, I'll keep it in mind for future diffs.

Closed by commit rCOMM42e7c48a2325: [native] Rename the lib directory to third-party (authored by rohan). · Explain WhyOct 6 2022, 6:09 PM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM42e7c48a2325: [native] Rename the lib directory to third-party.

Revision Contents
Changeset List

PathSize
native/
android/
app/
2 lines
cpp/
CommonCpp/
DatabaseManagers/
2 lines
lib/
sqlite_orm/
third-party/
sqlite_orm/
lib/
sqlite_orm/
ios/
Comm.xcodeproj/
6 lines

Diff 17394

View Options

native/android/app/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/CMakeLists.txt

Loading...
View Options

native/cpp/lib/sqlite_orm/CMakeLists.txt

Loading...
View Options

native/cpp/lib/sqlite_orm/LICENSE

Loading...
View Options

native/cpp/lib/sqlite_orm/sqlite_orm.h

Loading...
View Options

native/cpp/third-party/sqlite_orm/CMakeLists.txt

Loading...
View Options

native/cpp/third-party/sqlite_orm/LICENSE

Loading...
View Options

native/cpp/third-party/sqlite_orm/sqlite_orm.h

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...